Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1741] Include owners/admins can manage all collections setting in license file #3458

Merged
merged 69 commits into from
Dec 21, 2023

Commits on Aug 11, 2023

  1. [AC-1117] Add manage permission (#3126)

    * Update sql files to add Manage permission
    
    * Add migration script
    
    * Rename collection manage migration file to remove duplicate migration date
    
    * Migrations
    
    * Add manage to models
    
    * Add manage to repository
    
    * Add constraint to Manage columns
    
    * Migration lint fixes
    
    * Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
    
    * Add missing manage fields
    
    * Add 'Manage' to UserCollectionDetails
    
    * Use CREATE OR ALTER where possible
    differsthecat authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    4f08039 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145)

    * feat: update org table with new column, write migration, refs AC-1374
    
    * feat: update views with new column, refs AC-1374
    
    * feat: Alter sprocs (org create/update) to include new column, refs AC-1374
    
    * feat: update entity/data/request/response models to handle new column, refs AC-1374
    
    * feat: update necessary Provider related views during migration, refs AC-1374
    
    * fix: update org create to default new column to false, refs AC-1374
    
    * feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
    
    * fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
    
    * fix: dotnet format, refs AC-1374
    
    * feat: add ef migrations to reflect mssql changes, refs AC-1374
    
    * fix: dotnet format, refs AC-1374
    
    * feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
    vincentsalucci authored Aug 14, 2023
    Configuration menu
    Copy the full SHA
    cf78f12 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    78bdd51 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2023

  1. Configuration menu
    Copy the full SHA
    2f45726 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d5da5bb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2023

  1. Configuration menu
    Copy the full SHA
    e87c20c View commit details
    Browse the repository at this point in the history
  2. [AC-1174] CollectionUser and CollectionGroup authorization handlers (#…

    …3194)
    
    * [AC-1174] Introduce BulkAuthorizationHandler.cs
    
    * [AC-1174] Introduce CollectionUserAuthorizationHandler
    
    * [AC-1174] Add CreateForNewCollection CollectionUser requirement
    
    * [AC-1174] Add some more details to CollectionCustomization
    
    * [AC-1174] Formatting
    
    * [AC-1174] Add CollectionGroupOperation.cs
    
    * [AC-1174] Introduce CollectionGroupAuthorizationHandler.cs
    
    * [AC-1174] Cleanup CollectionFixture customization
    
    Implement and use re-usable extension method to support seeded Guids
    
    * [AC-1174] Introduce WithValueFromList AutoFixtureExtensions
    
    Modify CollectionCustomization to use multiple organization Ids for auto generated test data
    
    * [AC-1174] Simplify CollectionUserAuthorizationHandler.cs
    
    Modify the authorization handler to only perform authorization logic. Validation logic will need to be handled by any calling commands/controllers instead.
    
    * [AC-1174] Introduce shared CollectionAccessAuthorizationHandlerBase
    
    A shared base authorization handler was created for both CollectionUser and CollectionGroup resources, as they share the same underlying management authorization logic.
    
    * [AC-1174] Update CollectionUserAuthorizationHandler and CollectionGroupAuthorizationHandler to use the new CollectionAccessAuthorizationHandlerBase class
    
    * [AC-1174] Formatting
    
    * [AC-1174] Cleanup typo and redundant ToList() call
    
    * [AC-1174] Add check for provider users
    
    * [AC-1174] Reduce nested loops
    
    * [AC-1174] Introduce ICollectionAccess.cs
    
    * [AC-1174] Remove individual CollectionGroup and CollectionUser auth handlers and use base class instead
    
    * [AC-1174] Tweak unit test to fail minimally
    
    * [AC-1174] Reorganize authorization handlers in Core project
    
    * [AC-1174] Introduce new AddCoreAuthorizationHandlers() extension method
    
    * [AC-1174] Move CollectionAccessAuthorizationHandler into Api project
    
    * [AC-1174] Move CollectionFixture to Vault folder
    
    * [AC-1174] Rename operation to CreateUpdateDelete
    
    * [AC-1174] Require single organization for collection access authorization handler
    
    - Add requirement that all target collections must belong to the same organization
    - Simplify logic related to multiple organizations
    - Update tests and helpers
    - Use ToHashSet to improve lookup time
    
    * [AC-1174] Fix null reference exception
    
    * [AC-1174] Throw bad request exception when collections belong to different organizations
    
    * [AC-1174] Switch to CollectionAuthorizationHandler instead of CollectionAccessAuthorizationHandler to reduce complexity
    shane-melton authored Aug 30, 2023
    Configuration menu
    Copy the full SHA
    5dc3ca8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e8053e2 View commit details
    Browse the repository at this point in the history

Commits on Sep 1, 2023

  1. Configuration menu
    Copy the full SHA
    3dfd38c View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2023

  1. Configuration menu
    Copy the full SHA
    3c9c8ac View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    4ac1b10 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    064a28c View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Configuration menu
    Copy the full SHA
    acd3997 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. [AC-1125] Enforce org setting for creating/deleting collections (#3241)

    * [AC-1117] Add manage permission (#3126)
    
    * Update sql files to add Manage permission
    
    * Add migration script
    
    * Rename collection manage migration file to remove duplicate migration date
    
    * Migrations
    
    * Add manage to models
    
    * Add manage to repository
    
    * Add constraint to Manage columns
    
    * Migration lint fixes
    
    * Add manage to OrganizationUserUserDetails_ReadWithCollectionsById
    
    * Add missing manage fields
    
    * Add 'Manage' to UserCollectionDetails
    
    * Use CREATE OR ALTER where possible
    
    * [AC-1374] Limit collection creation/deletion to Owner/Admin (#3145)
    
    * feat: update org table with new column, write migration, refs AC-1374
    
    * feat: update views with new column, refs AC-1374
    
    * feat: Alter sprocs (org create/update) to include new column, refs AC-1374
    
    * feat: update entity/data/request/response models to handle new column, refs AC-1374
    
    * feat: update necessary Provider related views during migration, refs AC-1374
    
    * fix: update org create to default new column to false, refs AC-1374
    
    * feat: added new API/request model for collection management and removed property from update request model, refs AC-1374
    
    * fix: renamed migration script to be after secrets manage beta column changes, refs AC-1374
    
    * fix: dotnet format, refs AC-1374
    
    * feat: add ef migrations to reflect mssql changes, refs AC-1374
    
    * fix: dotnet format, refs AC-1374
    
    * feat: update API signature to accept Guid and explain Cd verbiage, refs AC-1374
    
    * feat: created collection auth handler/operations, added LimitCollectionCdOwnerAdmin to CurrentContentOrganization, refs AC-1125
    
    * feat: create vault service collection extensions and register with base services, refs AC-1125
    
    * feat: deprecated CurrentContext.CreateNewCollections, refs AC-1125
    
    * feat: deprecate DeleteAnyCollection for single resource usages, refs AC-1125
    
    * feat: move service registration to api, update references, refs AC-1125
    
    * feat: add bulk delete authorization handler, refs AC-1125
    
    * feat: always assign user and give manage access on create, refs AC-1125
    
    * fix: updated CurrentContextOrganization type, refs AC-1125
    
    * feat: combined existing collection authorization handlers/operations, refs AC-1125
    
    * fix: OrganizationServiceTests -> CurrentContentOrganization typo, refs AC-1125
    
    * fix: format, refs AC-1125
    
    * fix: update collection controller tests, refs AC-1125
    
    * fix: dotnet format, refs AC-1125
    
    * feat: removed extra BulkAuthorizationHandler, refs AC-1125
    
    * fix: dotnet format, refs AC-1125
    
    * fix: change string to guid for org id, update bulk delete request model, refs AC-1125
    
    * fix: remove delete many collection check, refs AC-1125
    
    * fix: clean up collection auth handler, refs AC-1125
    
    * fix: format fix for CollectionOperations, refs AC-1125
    
    * fix: removed unnecessary owner check, add org null check to custom permission validation, refs AC-1125
    
    * fix: remove unused methods in CurrentContext, refs AC-1125
    
    * fix: removed obsolete test, fixed failling delete many test, refs AC-1125
    
    * fix: CollectionAuthorizationHandlerTests fixes, refs AC-1125
    
    * fix: OrganizationServiceTests fix broken test by mocking GetOrganization, refs AC-1125
    
    * fix: CollectionAuthorizationHandler - remove unused repository, refs AC-1125
    
    * feat: moved UserId null check to common method, refs AC-1125
    
    * fix: updated auth handler tests to remove dependency on requirement for common code checks, refs AC-1125
    
    * feat: updated conditionals/comments for create/delete methods within colleciton auth handler, refs AC-1125
    
    * feat: added create/delete collection auth handler success methods, refs AC-1125
    
    * fix: new up permissions to prevent excessive null checks, refs AC-1125
    
    * fix: remove old reference to CreateNewCollections, refs AC-1125
    
    * fix: typo within ViewAssignedCollections method, refs AC-1125
    
    ---------
    
    Co-authored-by: Robyn MacCallum <robyntmaccallum@gmail.com>
    vincentsalucci and differsthecat authored Sep 18, 2023
    Configuration menu
    Copy the full SHA
    34dfdc5 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Configuration menu
    Copy the full SHA
    9f5fec6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ffa09d1 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2023

  1. Configuration menu
    Copy the full SHA
    f2acf1c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    2c7d02d View commit details
    Browse the repository at this point in the history
  2. [AC-1174] Bulk Collection Management (#3229)

    * [AC-1174] Update SelectionReadOnlyRequestModel to use Guid for Id property
    
    * [AC-1174] Introduce initial bulk-access collection endpoint
    
    * [AC-1174] Introduce BulkAddCollectionAccessCommand and validation logic/tests
    
    * [AC-1174] Add CreateOrUpdateAccessMany method to CollectionRepository
    
    * [AC-1174] Add event logs for bulk add collection access command
    
    * [AC-1174] Add User_BumpAccountRevisionDateByCollectionIds and database migration script
    
    * [AC-1174] Implement EF repository method
    
    * [AC-1174] Improve null checks
    
    * [AC-1174] Remove unnecessary BulkCollectionAccessRequestModel helpers
    
    * [AC-1174] Add unit tests for new controller endpoint
    
    * [AC-1174] Fix formatting
    
    * [AC-1174] Remove comment
    
    * [AC-1174] Remove redundant organizationId parameter
    
    * [AC-1174] Ensure user and group Ids are distinct
    
    * [AC-1174] Cleanup tests based on PR feedback
    
    * [AC-1174] Formatting
    
    * [AC-1174] Update CollectionGroup alias in the sproc
    
    * [AC-1174] Add some additional comments to SQL sproc
    
    * [AC-1174] Add comment explaining additional SaveChangesAsync call
    
    ---------
    
    Co-authored-by: Thomas Rittson <trittson@bitwarden.com>
    shane-melton and eliykat authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    5d431ad View commit details
    Browse the repository at this point in the history
  3. [AC-1646] Rename LimitCollectionCdOwnerAdmin column (#3300)

    * Rename LimitCollectionCdOwnerAdmin -> LimitCollectionCreationDeletion
    
    * Rename and bump migration script
    eliykat authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    a3f554a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Configuration menu
    Copy the full SHA
    30b91cd View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    dd10614 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2023

  1. [AC-1666] Removed EditAnyCollection from Create/Delete permission che…

    …cks (#3301)
    
    * fix: remove EditAnyCollection from Create/Delete permission check, refs AC-1666
    
    * fix: updated comment, refs AC-1666
    vincentsalucci authored Sep 29, 2023
    Configuration menu
    Copy the full SHA
    fbb7aa1 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. [AC-1669] Bug - Remove obsolete assignUserId from CollectionService.S…

    …aveAsync(...) (#3312)
    
    * fix: remove AssignUserId from CollectionService.SaveAsync, refs AC-1669
    
    * fix: add manage access conditional before creating collection, refs AC-1669
    
    * fix: move access logic for create/update, fix all tests, refs AC-1669
    
    * fix: add CollectionAccessSelection fixture, update tests, update bad reqeuest message, refs AC-1669
    
    * fix: format, refs AC-1669
    
    * fix: update null params with specific arg.is null checks, refs Ac-1669
    
    * fix: update attribute class name, refs AC-1669
    vincentsalucci authored Oct 5, 2023
    Configuration menu
    Copy the full SHA
    279d0cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0abd7c3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    fed3252 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Configuration menu
    Copy the full SHA
    6bc38ac View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. [AC-1713] [Flexible collections] Add feature flags to server (#3334)

    * Add feature flags for FlexibleCollections and BulkCollectionAccess
    
    * Flag new routes and behaviour
    
    ---------
    
    Co-authored-by: Rui Tomé <108268980+r-tome@users.noreply.github.com>
    eliykat and r-tome authored Oct 17, 2023
    Configuration menu
    Copy the full SHA
    3b049a6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    ae18e76 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2023

  1. Configuration menu
    Copy the full SHA
    52e723c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cd376be View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. [AC-1717] Update default values for LimitCollectionCreationDeletion (#…

    …3365)
    
    * Change default value in organization create sproc to 1
    
    * Drop old column name still present in some QA instances
    
    * Set LimitCollectionCreationDeletion value in code based on feature flag
    eliykat authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    ad27f3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d91eb23 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9d5c5bc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    596e0df View commit details
    Browse the repository at this point in the history
  5. [AC-1683] Fix DB migrations for new Manage permission (#3307)

    * [AC-1683] Update migration script and introduce V2 procedures and types
    
    * [AC-1683] Update repository calls to use new V2 procedures / types
    
    * [AC-1684] Update bulk add collection migration script to use new V2 type
    
    * [AC-1683] Undo Manage changes to more original procedures
    
    * [AC-1683] Restore whitespace changes
    
    * [AC-1683] Clarify comments regarding explicit column lists
    
    * [AC-1683] Update migration script dates
    
    * [AC-1683] Split the migration script for readability
    
    * [AC-1683] Re-name SelectReadOnlyArray_V2 to CollectionAccessSelectionType
    shane-melton authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    3a5c35b View commit details
    Browse the repository at this point in the history
  6. [AC-1648] [Flexible Collections] Bump migration scripts before featur…

    …e branch merge (#3371)
    
    * Bump dates on sql migration scripts
    
    * Bump date on ef migrations
    eliykat authored Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0fe97d7 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c11ba10 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Configuration menu
    Copy the full SHA
    51d1221 View commit details
    Browse the repository at this point in the history
  2. [AC-1720] Update stored procedures and views that query the organizat…

    …ion table and new column
    shane-melton committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    8d38740 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb2d02e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    69706ae View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b565bf5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d752f03 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    697f770 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    e6bbce7 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    dccd7bd View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2023

  1. Configuration menu
    Copy the full SHA
    b1f2d4f View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Configuration menu
    Copy the full SHA
    46437b4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2cc28b View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Configuration menu
    Copy the full SHA
    b10c700 View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2023

  1. Configuration menu
    Copy the full SHA
    e2feb58 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d806de8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d93aeb6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9bd7cc9 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    4407348 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. Configuration menu
    Copy the full SHA
    ea16218 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Configuration menu
    Copy the full SHA
    6bfb29a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Configuration menu
    Copy the full SHA
    d46d21d View commit details
    Browse the repository at this point in the history
  2. updated test fixture

    gbubemismith committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    94e1a97 View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2023

  1. updated test fixture

    gbubemismith committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    fc7212d View commit details
    Browse the repository at this point in the history
  2. linter fix

    gbubemismith committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    c1a7346 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4ac587c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    50254d3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2023

  1. Configuration menu
    Copy the full SHA
    fcc7067 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Configuration menu
    Copy the full SHA
    5ff8ab7 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34fdff0 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Configuration menu
    Copy the full SHA
    2a0afe7 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Configuration menu
    Copy the full SHA
    ec79719 View commit details
    Browse the repository at this point in the history