Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1772] Check null or whitespace on GatewayCustomerId and BillingEmail #3398

Merged
merged 4 commits into from
Nov 2, 2023
Merged

[AC-1772] Check null or whitespace on GatewayCustomerId and BillingEmail #3398

merged 4 commits into from
Nov 2, 2023

Conversation

amorask-bitwarden
Copy link
Contributor

@amorask-bitwarden amorask-bitwarden commented Nov 1, 2023 •
edited
Loading

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@amorask-bitwarden amorask-bitwarden requested a review from a team as a code owner November 1, 2023 13:55
@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud November 1, 2023 14:21 Inactive
@bitwarden-bot
Copy link

bitwarden-bot commented Nov 1, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 0c28a26e-6f6f-47d3-ba6e-03c6dc2e3651

No New Or Fixed Issues Found

@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud November 1, 2023 15:23 Inactive
@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to EU-QA Cloud November 1, 2023 16:08 Inactive
@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud November 1, 2023 16:47 Inactive
eliykat
eliykat reviewed Nov 2, 2023
View reviewed changes
Copy link
Member

@eliykat eliykat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know this is a hotfix so these can be follow up items.

src/Admin/Controllers/OrganizationsController.cs Show resolved Hide resolved
src/Admin/Controllers/OrganizationsController.cs Show resolved Hide resolved
@cturnbull-bitwarden cturnbull-bitwarden merged commit cfe9812 into master Nov 2, 2023
41 of 43 checks passed
@cturnbull-bitwarden cturnbull-bitwarden deleted the billing/AC-1772/manual-trials-broken branch November 2, 2023 14:23
cturnbull-bitwarden pushed a commit that referenced this pull request Nov 2, 2023
@amorask-bitwarden @cturnbull-bitwarden
[AC-1772] Check null or whitespace on GatewayCustomerId and `Billin…
75bb84c 
…gEmail` (#3398)

* Check null or whitespace on GatewayCustomerId and BillingEmail

* Fixed expiration input
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliykat eliykat eliykat left review comments

@cturnbull-bitwarden cturnbull-bitwarden cturnbull-bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@amorask-bitwarden @bitwarden-bot @eliykat @cturnbull-bitwarden @bitwarden-devops-bot