Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SG-497] Prevent registering health check on self hosted #3058

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

gbubemismith
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Due to ongoing discussions, it would make sense not to allow the health check endpoint on self-hosted.

Code changes

I've updated the health checks to not register when the application is self-hosted. Additionally, I replaced the usage of string.IsNullOrEmpty with CoreHelpers.SettingHasValue for a more reliable way to check if a setting has been provided.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@gbubemismith gbubemismith requested a review from a team June 30, 2023 15:15
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the formatting issue you're getting but otherwise looks good to me.

src/Api/Startup.cs Outdated Show resolved Hide resolved
Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate this! Solid result for all our customers.

@gbubemismith gbubemismith merged commit b87e6d4 into master Jun 30, 2023
@gbubemismith gbubemismith deleted the fix/SG-497 branch June 30, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants