[SM-787] Extract authorization from project delete command #2987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coltonhurst
previously approved these changes
Jun 13, 2023
|
New Issues
Fixed Issues
|
coltonhurst
approved these changes
Jul 7, 2023
withinfocus
approved these changes
Jul 10, 2023
| projectSecret.RevisionDate = utcNow; | ||
| } | ||
|
|
||
| dbContext.Remove(project); |
There was a problem hiding this comment.
| if (authorizationResult.Succeeded) | ||
| { | ||
| projectsToDelete.Add(project); | ||
| results.Add((project, "")); |
There was a problem hiding this comment.
⛏️ I prefer the cleanliness of string.Empty vs. the literal here.
| @@ -4,5 +4,5 @@ public enum PermissionType | |||
| { | |||
| RunAsAdmin, | |||
| RunAsUserWithPermission, | |||
| RunAsServiceAccountWithPermission | |||
| RunAsServiceAccountWithPermission, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
The purpose of this PR is to refactor authorization out of the
DeleteProjectCommand.Code changes
bitwarden_license/src/Commercial.Core/SecretsManager/AuthorizationHandlers/Projects/ProjectAuthorizationHandler.cs:
Adding delete to project authorization handler.
bitwarden_license/src/Commercial.Core/SecretsManager/Commands/Projects/DeleteProjectCommand.cs:
src/Core/SecretsManager/Commands/Projects/Interfaces/IDeleteProjectCommand.cs:
Extracting authorization from the delete project command.
Removing the extra call to update revision dates in favor of encapsulating the update all in one transaction via
DeleteManyByIdAsync.bitwarden_license/src/Commercial.Infrastructure.EntityFramework/SecretsManager/Repositories/ProjectRepository.cs:
Adding in updating the revision date of secrets associated with the projects being deleted, so this can all be in one database transaction.
bitwarden_license/test/Commercial.Core.Test/SecretsManager/AuthorizationHandlers/Projects/ProjectAuthorizationHandlerTests.cs:
Adding in unit test coverage for the delete operation and consolidating update boolean mapping tests.
bitwarden_license/test/Commercial.Core.Test/SecretsManager/Commands/Projects/DeleteProjectCommandTests.cs:
Updating unit test coverage for the
DeleteProjectCommandsince authorization is now extracted out.src/Api/SecretsManager/Controllers/ProjectsController.cs:
Updating the bulk delete controller to utilize the project authorization handler.
src/Core/SecretsManager/AuthorizationRequirements/ProjectOperationRequirement.cs:
Adding delete as an option for
ProjectOperationRequirementtest/Api.Test/SecretsManager/Controllers/ProjectsControllerTests.cs:
Adding unit test coverage for authorization handler and controller code updates.
Before you submit
dotnet format --verify-no-changes) (required)