Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set internal vault uri correctly #2849

Merged
merged 3 commits into from
Apr 14, 2023
Merged

set internal vault uri correctly #2849

merged 3 commits into from
Apr 14, 2023

Conversation

kspearrin
Copy link
Member

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Resolves #2530

Set internal vault URI env variable dynamically.

Code changes

  • Dockerfile: Change default value to 8080 port.
  • entrypoint.sh: Set internal vault uri based on port env variables and SSL settings.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@kspearrin kspearrin requested a review from vgrassia April 12, 2023 12:40
docker-unified/entrypoint.sh Outdated Show resolved Hide resolved
docker-unified/entrypoint.sh Outdated Show resolved Hide resolved
kspearrin and others added 2 commits April 13, 2023 12:29
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
@kspearrin
Copy link
Member Author

Nice catch

@kspearrin kspearrin requested a review from vgrassia April 13, 2023 16:30
@kspearrin kspearrin merged commit 09c1b2e into master Apr 14, 2023
@kspearrin kspearrin deleted the intvault branch April 14, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web Installed: Unable to fetch installed version
2 participants