Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-1506] fix: mssql error when running docker compose #2810

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

skaiser
Copy link
Contributor

@skaiser skaiser commented Mar 18, 2023

Type of change

- [X] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Fixes the error message, "services.mssql.environment.ACCEPT_EULA must be a string, number or null" when running docker compose --profile mssql --profile mail up -d during initial dev setup on MacOS.

Code changes

  • dev/docker-compose.yml: Changed ACCEPT_EULA from Y to "Y". There are also some auto-formatting changes that removed trailing whitespace and made all quotes consistently double quotes.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

Fixes the error message, "services.mssql.environment.ACCEPT_EULA must be a string, number or null" when running `docker compose --profile mssql --profile mail up -d` during initial dev setup on MacOS.
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-1506

@bitwarden-bot bitwarden-bot changed the title fix: mssql error when running docker compose [PM-1506] fix: mssql error when running docker compose Mar 18, 2023
@skaiser
Copy link
Contributor Author

skaiser commented Mar 20, 2023

FYI, my docker --version == Docker version 20.10.7, build f0df350

@justindbaur justindbaur self-assigned this Mar 23, 2023
@justindbaur justindbaur self-requested a review March 23, 2023 15:36
Copy link
Member

@justindbaur justindbaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks for the contribution!

@justindbaur justindbaur merged commit 3b50ccb into bitwarden:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants