Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1105] allow users with manage groups permission to access collect… #2780

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

jlf0dev
Copy link
Member

@jlf0dev jlf0dev commented Mar 7, 2023

…ions

Type of change

- [x] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

As a user with the Manage Groups permission, you can access both the Vault and Groups tab in the Admin Console. Those pages both use Collections, but just because you have the Manage Groups permission, doesn't mean you can access those collections used in the page.

This change allows users with the Manage Groups permission to use the collection endpoints. This will not allow them to access all collection, just assigned collections.

Code changes

  • file.ext: Description of what was changed and why

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@jlf0dev jlf0dev requested a review from a team March 7, 2023 21:21
@eliykat
Copy link
Member

eliykat commented Mar 9, 2023

So "Manage Groups" means you can create, delete and edit groups, but you can't give groups access to collections that you yourself do not have access to. Is that the intention?

If so then LGTM. I am just unsure how custom permissions are supposed to interact so I wanted to make sure.

@jlf0dev jlf0dev removed the needs-qa label Mar 13, 2023
@jlf0dev jlf0dev merged commit 2f6e463 into master Mar 13, 2023
@jlf0dev jlf0dev deleted the ac-1105-groups-permissions-bug branch March 13, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants