Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC 480]Add the organization name to the stripe invoice #2772

Merged

Conversation

cyprain-okeke
Copy link
Contributor

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Add Organization Name to the stripe invoice

Code changes

  • src/Core/Services/Implementations/StripePaymentService.cs: add the organization name to the CustomFields of the InvoiceSettings on CustomerCreateAsync
  • src/Core/Entities/ISubscriber.cs: add the organizationName to the ISubscriber interface and implement it on Organization and user class to enable the return organization name which is used on the InvoiceSettings of CustomerCreateAsync

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • If making database changes - make sure you also update Entity Framework queries and/or migrations
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

@cyprain-okeke cyprain-okeke requested a review from a team March 6, 2023 23:03
src/Core/Entities/User.cs Outdated Show resolved Hide resolved
src/Core/Entities/User.cs Outdated Show resolved Hide resolved
src/Core/Services/Implementations/StripePaymentService.cs Outdated Show resolved Hide resolved
src/Core/Services/Implementations/StripePaymentService.cs Outdated Show resolved Hide resolved
src/Core/Services/Implementations/StripePaymentService.cs Outdated Show resolved Hide resolved
src/Core/Services/Implementations/StripePaymentService.cs Outdated Show resolved Hide resolved
Copy link
Member

@eliykat eliykat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I don't know how the invoice layout works in the Stripe dashboard, so I'm assuming that you've checked that out and this is the metadata we need.

Just 1 very minor formatting nit. You can fix it and then move the ticket to QA in the meantime, I'll approve tomorrow.

src/Core/Services/Implementations/StripePaymentService.cs Outdated Show resolved Hide resolved
eliykat
eliykat previously approved these changes Mar 16, 2023
@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud March 29, 2023 01:49 Inactive
Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I left a suggestion regarding the custom fields that I think would make the code easier to maintain.

Copy link
Contributor

@r-tome r-tome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@bitwarden-devops-bot bitwarden-devops-bot temporarily deployed to QA Cloud April 6, 2023 14:16 Inactive
@eliykat
Copy link
Member

eliykat commented Apr 7, 2023

If Rui's happy then I'm happy ;)

@eliykat eliykat removed their request for review April 7, 2023 04:11
@cyprain-okeke cyprain-okeke merged commit 6d7bcd9 into master Apr 7, 2023
@cyprain-okeke cyprain-okeke deleted the ac-480/add-the-organization-name-to-the-stripe-invoice branch April 7, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants