-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[EC-144] Fix stripe revert logic #2014
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we paired on this, feel free to ask for more reviews, but I'll go ahead and approve.
Also, nice job on the QA test notes (I know most people here can't read them since we moved them to jira, but trust me, they're thorough)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one question.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Type of change
Objective
Fixes an issue where reverting a subscription update would fail.
Props to @MGibson1 for pairing and supporting on this!!
Code changes
Before you submit
dotnet tool run dotnet-format --check
) (required)