[euvr] Separate Billing Payment/History APIs #1932
Conversation
| @@ -640,6 +640,34 @@ public async Task<BillingResponseModel> GetBilling() | |||
| return new BillingResponseModel(billingInfo); | |||
| } | |||
There was a problem hiding this comment.
Do we still need this now that it's split into two requests? (I believe we're only fetching it from web which is a place that gets released in sync with server.)
There was a problem hiding this comment.
While that generally is the case, I feel more comfortable not committing breaking changes to the API at the initial release.
There was a problem hiding this comment.
Do we have a tech debt to remove this before the next release?
There was a problem hiding this comment.
Created tech debt item and self-assigned for a future release. 👍
Since this is only net-new with no breaking changes, I don't see why not. However, I'm 100% okay with pointing this to an |
…ied PaymentService helpers
|
Added hold label to ensure we don't merge this before the code freeze elapses. |
|
|
Type of change
Objective
Code changes
billing-historyandbilling-paymentAPI endpointsInvoicesandTransactionsBalanceandPaymentSourceGetBillingHistoryAsyncandGetBillingBalanceAndSourceAsyncGetBillingAsyncmethod by breaking out different properties into functions that can be used independently. Created new methodsGetBillingHistoryAsyncandGetBillingBalanceAndSourceAsyncfor grabbing only the necessary information.Testing requirements
Settings -> SubscriptionOrganization Settings -> Billingas that will still use theGetBillingAPI that's in place (backwards-compat)Before you submit
dotnet tool run dotnet-format --check) (required)