Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove falsely added Microsoft.Azure.Storage.Blobs #1845

Merged
merged 1 commit into from
Feb 9, 2022

Conversation

djsmith85
Copy link
Contributor

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With #1732 I migrated Microsoft.Azure.Storage.Blobs to Azure.Storage.Blobs but with #1759 it got falsely added again.

Code changes

  • src/Core/Core.csproj: Uninstalled Microsoft.Azure.Storage.Blobs

Testing requirements

No testing needed, as dependency is not referenced anywhere.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • If making database changes - I have also updated Entity Framework queries and/or migrations
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 requested a review from a team February 9, 2022 11:39
@djsmith85 djsmith85 merged commit cecf052 into master Feb 9, 2022
@djsmith85 djsmith85 deleted the Remove-Microsoft.Azure.Storage.Blobs branch February 9, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants