Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-5693] CryptoService using memfd_secret on Linux #979

Closed
wants to merge 41 commits into from

Try updating windows in memsec

45f3d32
Select commit
Loading
Failed to load commit list.
Closed

[PM-5693] CryptoService using memfd_secret on Linux #979

Try updating windows in memsec
45f3d32
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 24, 2024 in 1s

60.23% (+1.95%) compared to 0747621

View this Pull Request on Codecov

60.23% (+1.95%) compared to 0747621

Details

Codecov Report

Attention: Patch coverage is 86.18290% with 139 lines in your changes missing coverage. Please review.

Project coverage is 60.23%. Comparing base (0747621) to head (45f3d32).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-crypto/src/service/context.rs 37.50% 80 Missing โš ๏ธ
crates/bitwarden-crypto/src/service/encryptable.rs 53.84% 36 Missing โš ๏ธ
...tes/bitwarden-crypto/src/service/key_store/util.rs 97.84% 12 Missing โš ๏ธ
crates/bitwarden-crypto/src/service/mod.rs 94.62% 5 Missing โš ๏ธ
...itwarden-crypto/src/service/key_store/rust_impl.rs 95.58% 3 Missing โš ๏ธ
crates/bitwarden-core/src/lib.rs 97.10% 2 Missing โš ๏ธ
...ates/bitwarden-crypto/src/service/key_store/mod.rs 88.88% 1 Missing โš ๏ธ
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   58.27%   60.23%   +1.95%     
==========================================
  Files         192      199       +7     
  Lines       13486    14492    +1006     
==========================================
+ Hits         7859     8729     +870     
- Misses       5627     5763     +136     

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.