[PM-13371] Repository split - Avoid depdending on Bitwarden #1124
Conversation
|
No New Or Fixed Issues Found |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1124 +/- ##
==========================================
+ Coverage 58.31% 58.37% +0.05%
==========================================
Files 193 193
Lines 13553 13541 -12
==========================================
Hits 7904 7904
+ Misses 5649 5637 -12 ☔ View full report in Codecov by Sentry. |
Hinton
changed the title
# Conflicts: # crates/sdk-schemas/Cargo.toml
| @@ -16,8 +16,7 @@ repository.workspace = true | |||
| license-file.workspace = true | |||
|
|
|||
| [features] | |||
| internal = ["bitwarden/internal"] # Internal testing methods | |||
| secrets = ["bitwarden/secrets"] # Secrets manager API | |||
| secrets = ["bitwarden/secrets"] # Secrets manager API | |||
There was a problem hiding this comment.
If bitwarden-json is going to be a secrets manager only crate now, we can probably remove the secrets feature as well right?
| E(bitwarden::error::Error), | ||
| } | ||
| #[error(transparent)] | ||
| Core(#[from] bitwarden_core::Error), |
There was a problem hiding this comment.
This will probably be a breaking change for the mobile apps, we will need to notify them before we make a new release.
There was a problem hiding this comment.
True, I reverted it we should find some time to resolve the external error issue in uniffi.
🎟️ Tracking
Epic: https://bitwarden.atlassian.net/browse/PM-13370
Phase: https://bitwarden.atlassian.net/browse/PM-13371
📔 Objective
Decouples our internal crates from depending on the public
bitwardencrate.uniffi,wasm-internalandbwnow depends directly on feature crates.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes