Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to using npm for sdk-internal #1113

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Switch to using npm for sdk-internal #1113

merged 1 commit into from
Oct 4, 2024

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Oct 4, 2024

๐ŸŽŸ๏ธ Tracking

๐Ÿ“” Objective

It's a hassle to consume an package published on GitHub Packages in GitHub Actions as you need a PAT. Proposing we switch to publishing on npm instead.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@Hinton Hinton requested a review from a team as a code owner October 4, 2024 10:07
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Logo
Checkmarx One โ€“ Scan Summary & Details โ€“ 260124c7-e485-4bec-b6f9-55407ea50de1

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /publish-internal.yml: 62 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests โœ…

Project coverage is 58.32%. Comparing base (e0a4c2e) to head (055e1e0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1113   +/-   ##
=======================================
  Coverage   58.32%   58.32%           
=======================================
  Files         193      193           
  Lines       13557    13557           
=======================================
  Hits         7907     7907           
  Misses       5650     5650           

โ˜” View full report in Codecov by Sentry.
๐Ÿ“ข Have feedback on the report? Share it here.

@Hinton Hinton merged commit bb93c23 into main Oct 4, 2024
95 of 100 checks passed
@Hinton Hinton deleted the ps/publish-public branch October 4, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants