[BRE-224] Create a GitHub release workflows for sdk #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub-Release-workflows-for-SDK
|
New Issues
Fixed Issues
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
=======================================
Coverage 58.31% 58.31%
=======================================
Files 192 192
Lines 13486 13486
=======================================
Hits 7865 7865
Misses 5621 5621 ☔ View full report in Codecov by Sentry. |
vgrassia
requested changes
Sep 25, 2024
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
vgrassia
requested changes
Sep 26, 2024
.github/workflows/publish-wasm.yml
Outdated
| workflow: build-wasm.yml | ||
| path: ${{ github.workspace }}/languages/js/wasm | ||
| workflow_conclusion: success | ||
| branch: ${{ inputs.release_type == 'Dry Run' && 'main' || github.ref_name }} |
There was a problem hiding this comment.
Suggested change
| branch: ${{ inputs.release_type == 'Dry Run' && 'main' || github.ref_name }} | |
| branch: main |
Is the Download artifacts step being used, or the one below this for Download artifact?
There was a problem hiding this comment.
The one below. Fixed it.
.github/workflows/publish-napi.yml
Outdated
Comment on lines
16
to
20
| npm_publish: | ||
| description: "Publish to NPM registry" | ||
| required: true | ||
| default: true | ||
| type: boolean |
There was a problem hiding this comment.
Suggested change
| npm_publish: | |
| description: "Publish to NPM registry" | |
| required: true | |
| default: true | |
| type: boolean |
Since this workflow only publishes to NPM, we can remove the input. It would do nothing if the box was not checked.
.github/workflows/publish-napi.yml
Outdated
| name: Publish NPM | ||
| runs-on: ubuntu-22.04 | ||
| needs: setup | ||
| if: inputs.npm_publish |
There was a problem hiding this comment.
Suggested change
| if: inputs.npm_publish |
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
…ttps://github.com/bitwarden/sdk into BRE-224-Create-a-GitHub-Release-workflows-for-SDK
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
vgrassia
requested changes
Sep 26, 2024
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
Co-authored-by: Vince Grassia <593223+vgrassia@users.noreply.github.com>
…ub-Release-workflows-for-SDK
…ttps://github.com/bitwarden/sdk into BRE-224-Create-a-GitHub-Release-workflows-for-SDK
vgrassia
approved these changes
Sep 30, 2024
michalchecinski
deleted the
BRE-224-Create-a-GitHub-Release-workflows-for-SDK
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/BRE-224
📔 Objective
Create and/or split workflow to create a GitHub Release for SDK parts.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes