Skip to content

Conversation

@dani-garcia
Copy link
Member

🎟️ Tracking

📔 Objective

The rust version set in the memory-testing dockerfile is going out of sync with the one defined in rust-toolchain.toml. I've updated the renovate config to ensure they stay in sync, and that renovate will open a single PR for them.

Discovered here: #531

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2b3346fd-8210-4ed2-8125-5cc18d2d3ec6

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: ps/group-rust-updates (4a2811e)
Completed: 2025-11-20 12:22:43 UTC
Total Time: 248s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@dani-garcia dani-garcia marked this pull request as ready for review November 20, 2025 12:24
@dani-garcia dani-garcia requested a review from a team as a code owner November 20, 2025 12:24
@claude

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.63%. Comparing base (b5b6e90) to head (4a2811e).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #568   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files         302      302           
  Lines       32248    32248           
=======================================
  Hits        25682    25682           
  Misses       6566     6566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia
Copy link
Member Author

@claude The mismatch is not problematic and will be fixed in the next renovate run automatically once this PR is merged

@claude
Copy link

claude bot commented Nov 20, 2025

Claude finished @dani-garcia's task —— View job


🔍 Code Review Complete

Summary: This PR adds a renovate package rule to group Rust version updates across rust-toolchain.toml and dockerfiles, preventing version drift.


📋 Review Feedback

Renovate Configuration

The renovate configuration change is well-structured and follows best practices:

{
  "groupName": "rust",
  "matchManagers": ["custom.regex", "dockerfile"],
  "matchDepNames": ["rust"]
}

Good practices observed:

  • Correctly matches both custom.regex (for rust-toolchain.toml) and dockerfile managers
  • Uses consistent naming pattern with existing rules
  • Placed logically at the top of packageRules array

Current Version Mismatch

There's currently a version mismatch between:

  • rust-toolchain.toml: 1.87.0
  • crates/memory-testing/Dockerfile: 1.89-alpine

Resolution: Per author confirmation, this mismatch is intentional and will be automatically resolved by Renovate in the next update cycle after this PR merges. The new grouping rule ensures future updates stay synchronized.


✅ Recommendation

This PR is ready to merge. The configuration change achieves its stated objective of preventing future version drift between Rust toolchain and dockerfile specifications.


@dani-garcia dani-garcia merged commit 1a076a1 into main Nov 21, 2025
61 checks passed
@dani-garcia dani-garcia deleted the ps/group-rust-updates branch November 21, 2025 18:39
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants