Skip to content

Conversation

@coroiu
Copy link
Contributor

@coroiu coroiu commented Nov 20, 2025

🎟️ Tracking

📔 Objective

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from a team as a code owner November 20, 2025 08:56
@coroiu coroiu requested a review from dani-garcia November 20, 2025 08:56
@claude
Copy link

claude bot commented Nov 20, 2025

Claude finished @coroiu's task —— View job


Code Review

Summary of Changes

This PR adds documentation clarifying that npm dependencies must be installed before building the WASM internal crate, specifying the correct directories for both OSS and commercial builds.

Findings

Finding 1: PR description is incomplete 💭

The PR template sections are empty:

  • 🎟️ Tracking: Missing Jira reference
  • 📔 Objective: Missing explanation of what changed and why
Suggested PR description improvements

Title: Current title is clear and descriptive ✓

Objective section could be:

## 📔 Objective

Clarifies the build requirements for `bitwarden-wasm-internal` by documenting that npm dependencies must be installed before building. This addresses a common setup issue where developers encounter build failures due to missing npm packages.

The documentation now explicitly lists both OSS and commercial npm directories where `npm ci` should be run.

Tracking section should include the relevant Jira ticket if one exists.

Finding 2: Documentation accuracy verified ✓

The paths referenced in the documentation are correct:

  • crates/bitwarden-wasm-internal/npm exists with package.json
  • crates/bitwarden-wasm-internal/bitwarden_license/npm exists with package.json

Good Practices Observed

  • Uses npm ci instead of npm install (ensures reproducible builds)
  • Clearly distinguishes between OSS and commercial build paths
  • Placed in logical location within existing Requirements section

Action Items

  • Add Jira reference to Tracking section (if applicable)
  • Fill in Objective section explaining the purpose of this documentation change

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsdde0b76d-9d84-4848-9882-11f7404cbcc2

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: coroiu/add-npm-ci-to-wasm-internal (39962d7)
Completed: 2025-11-20 09:06:08 UTC
Total Time: 218s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.63%. Comparing base (de5ff02) to head (39962d7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #567   +/-   ##
=======================================
  Coverage   79.63%   79.63%           
=======================================
  Files         302      302           
  Lines       32248    32248           
=======================================
  Hits        25682    25682           
  Misses       6566     6566           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@coroiu coroiu merged commit b5b6e90 into main Nov 20, 2025
58 checks passed
@coroiu coroiu deleted the coroiu/add-npm-ci-to-wasm-internal branch November 20, 2025 09:38
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants