-
Notifications
You must be signed in to change notification settings - Fork 25
Add npm ci to wasm internal docs
#567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Claude finished @coroiu's task —— View job Code ReviewSummary of ChangesThis PR adds documentation clarifying that npm dependencies must be installed before building the WASM internal crate, specifying the correct directories for both OSS and commercial builds. FindingsFinding 1: PR description is incomplete 💭 The PR template sections are empty:
Suggested PR description improvementsTitle: Current title is clear and descriptive ✓ Objective section could be: ## 📔 Objective
Clarifies the build requirements for `bitwarden-wasm-internal` by documenting that npm dependencies must be installed before building. This addresses a common setup issue where developers encounter build failures due to missing npm packages.
The documentation now explicitly lists both OSS and commercial npm directories where `npm ci` should be run.Tracking section should include the relevant Jira ticket if one exists. Finding 2: Documentation accuracy verified ✓ The paths referenced in the documentation are correct:
Good Practices Observed
Action Items
|
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #567 +/- ##
=======================================
Coverage 79.63% 79.63%
=======================================
Files 302 302
Lines 32248 32248
=======================================
Hits 25682 25682
Misses 6566 6566 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…asm internal docs (bitwarden/sdk-internal#567)

🎟️ Tracking
📔 Objective
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes