Skip to content

Conversation

@theMickster
Copy link
Contributor

@theMickster theMickster commented Nov 13, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-27181
https://bitwarden.atlassian.net/browse/BRE-1331

📔 Objective

Implement our respond workflow so that engineers may leverage callouts to Claude using @claude: ___
Grant additional permissions for the reusable review workflow to ensure that we can also execute the reusable workflow in private repos.

Order matters when updating because:

  1. If you add a required permission to the reusable workflow definition without callers having it, those workflows will fail
  2. Callers can grant more permissions than the reusable workflow requires without breaking
  3. Reusable workflows cannot grant themselves permissions - they can only use what the caller provides

Further information on proper permissions found below

  1. Reuse Workflow - GitHub
  2. Workflow syntax for GitHub Actions

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@theMickster theMickster requested a review from a team as a code owner November 13, 2025 12:39
@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsbf1a5853-c65e-46b4-97c5-4e70cd7a84bf

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Nov 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.69%. Comparing base (b1cf684) to head (929f522).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #558   +/-   ##
=======================================
  Coverage   79.69%   79.69%           
=======================================
  Files         300      300           
  Lines       32220    32220           
=======================================
  Hits        25679    25679           
  Misses       6541     6541           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@theMickster theMickster requested a review from a team November 13, 2025 13:57
@theMickster theMickster merged commit f7ff6c7 into main Nov 13, 2025
57 of 58 checks passed
@theMickster theMickster deleted the ai/respond-workflow-and-permission-adjustment branch November 13, 2025 15:07
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Nov 13, 2025
…ement respond workflow + grant proper permissions for review workflow (bitwarden/sdk-internal#558)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants