Skip to content

Conversation

@dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Sep 22, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-23512

📔 Objective

Create the bitwarden-pm crate that will sit between bitwarden-core and bitwarden-wasm/uniffi and will encapsulate all the password manager functionality. Note that uniffi is still mostly reimplementing the API due to #424, so this doesn't change that much.

I've also made the bitwarden-pm crate reexport the clients from the feature crates, which allows us to remove them from the wasm-crate.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

Logo
Checkmarx One – Scan Summary & Detailsb6a863e2-d336-4192-97c8-23a0be8a03cd

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

❌ Patch coverage is 0% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.16%. Comparing base (e30f1ea) to head (dd7d7bd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-pm/src/lib.rs 0.00% 30 Missing ⚠️
crates/bitwarden-wasm-internal/src/client.rs 0.00% 9 Missing ⚠️
crates/bitwarden-uniffi/src/lib.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
- Coverage   78.25%   78.16%   -0.10%     
==========================================
  Files         275      276       +1     
  Lines       27447    27479      +32     
==========================================
  Hits        21479    21479              
- Misses       5968     6000      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

@dani-garcia dani-garcia marked this pull request as ready for review September 22, 2025 11:54
@dani-garcia dani-garcia requested a review from a team as a code owner September 22, 2025 11:54
@dani-garcia dani-garcia requested a review from coroiu September 22, 2025 11:54
@dani-garcia dani-garcia merged commit 7878bdb into main Sep 22, 2025
68 of 69 checks passed
@dani-garcia dani-garcia deleted the ps/PM-23512-create-bitwarden-pm branch September 22, 2025 12:34
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants