Skip to content

Conversation

@eliykat
Copy link
Member

@eliykat eliykat commented Oct 22, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13910

📔 Objective

Add the Collection.Manage boolean property, which is missing from the SDK but which needs to be made available to mobile clients.

It is already returned in the server response and is in the autogenerated response model.

This is my first commit to the SDK, please let me know if I've missed anything.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details2077ceac-a0ad-4936-97ed-70dca13af4eb

No New Or Fixed Issues Found

@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.86%. Comparing base (f7202ab) to head (9e53da2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bitwarden-vault/src/collection.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main       #4   +/-   ##
=======================================
  Coverage   62.85%   62.86%           
=======================================
  Files         179      179           
  Lines       12681    12685    +4     
=======================================
+ Hits         7971     7974    +3     
- Misses       4710     4711    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eliykat eliykat marked this pull request as ready for review October 22, 2024 09:54
@eliykat eliykat requested a review from dani-garcia October 22, 2024 09:54
Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Thomas!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants