[PM-24051] MasterPasswordUnlockData model with response mapping and adds it to identity success response model #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
==========================================
+ Coverage 76.41% 76.53% +0.12%
==========================================
Files 265 267 +2
Lines 24433 24651 +218
==========================================
+ Hits 18670 18867 +197
- Misses 5763 5784 +21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mzieniukbw
requested review from
a team and
quexten
and removed request for
a team
quexten
requested changes
Aug 6, 2025
Contributor
quexten
left a comment
quexten
left a comment
There was a problem hiding this comment.
Some initial comments, some of these are required, some are idiomatic (but probably required since the quality bar for SDK seems to be set much higher).
I'd like a review from someone with more rust experience such as @Hinton or @dani-garcia too. I believe specifically the request parsing is something that has not existed in the SDK so far, and there may be a better way to do this that we're unaware of.
crates/bitwarden-wasm-internal/src/key_management/master_password.rs
Outdated
Show resolved
Hide resolved
Hinton
reviewed
Aug 26, 2025
quexten
previously approved these changes
Aug 26, 2025
quexten
previously approved these changes
Aug 27, 2025
Hinton
reviewed
Aug 28, 2025
Hinton
reviewed
Aug 28, 2025
…ption-options-to-identity-sync-response
|
Hinton
approved these changes
Sep 1, 2025
quexten
approved these changes
Sep 1, 2025
justindbaur
approved these changes
Sep 2, 2025
mzieniukbw
deleted the
km/pm-24051-add-master-password-unlock-decryption-options-to-identity-sync-response
branch
This was referenced Sep 3, 2025
nikwithak
added a commit
that referenced
this pull request
Sep 23, 2025
…dds it to identity success response model (#376) https://bitwarden.atlassian.net/browse/PM-24051 Adds `MasterPasswordUnlockData` model with `MasterPasswordUnlockResponseModel` mapping. This wi Adds `UserDecryptionOptionsResponseModel` into the identity success token response. This model includes the master password unlock field. The `/sync` response model is autogenerated by OpenApi and already includes user decryption option and the master password unlock fields. Includes Uniffi and WASM bindings for `MasterPasswordUnlock`. In further PR's we plan to use the `MasterPasswordUnlock` in `InitUserCryptoMethod` enum - this is still in discussion. - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
mzieniukbw
added a commit
that referenced
this pull request
Oct 16, 2025
## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-24051 ## 📔 Objective - Initialise user crypto with `MasterPasswordUnlock` - added `initialize_user_crypto_master_password_unlock` function into `InternalClient`'s crypto. - Auth's login methods (password, and api_key specifically) use `MasterPasswordUnlockData` when present in response and uses new function. - KM team have decided that the double KDF derivation issue is something we are ok with for login. - Moved `set_login_method` to be the after the `initialize_user_crypto` function in execution order, since the latter overrides the `set_login_method`. Move everywhere (all login methods) for consistency. - Removed `kdf` as init arg of `password.rs`, consistently use `prelogin` now. - Update user's KDF settings with `MasterPasswordUnlock` via `update_user_master_password_unlock` in `InternalClient`, triggered in sync. Continuation of #376 ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24051
📔 Objective
Adds
MasterPasswordUnlockDatamodel withMasterPasswordUnlockResponseModelmapping. This wiAdds
UserDecryptionOptionsResponseModelinto the identity success token response. This model includes the master password unlock field.The
/syncresponse model is autogenerated by OpenApi and already includes user decryption option and the master password unlock fields.Includes Uniffi and WASM bindings for
MasterPasswordUnlock.In further PR's we plan to use the
MasterPasswordUnlockinInitUserCryptoMethodenum - this is still in discussion.⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes