Skip to content

Conversation

@dani-garcia
Copy link
Member

@dani-garcia dani-garcia commented Jul 11, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-22690

📔 Objective

Create an initial CLI skeleton, trying to maintain compatibility with the node CLI

  • Moved the main command struct to a separate file as it's getting big now
  • Created team based files for the command code
  • Created some utilities for formatting the output
  • The command structure mostly matches the Node CLI now, with some differences around Login
  • Implemented some basic commands like encode and generate, which match the Node CLI, the rest are unimplemented

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2025

Logo
Checkmarx One – Scan Summary & Detailsc6c3452e-c525-4f0f-8983-13bf7e1ebbfc

Great job! No new security vulnerabilities introduced in this pull request

@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

❌ Patch coverage is 0% with 204 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.15%. Comparing base (824c1cf) to head (ffebb9b).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/bw/src/main.rs 0.00% 64 Missing ⚠️
crates/bw/src/render.rs 0.00% 50 Missing ⚠️
crates/bw/src/tools/mod.rs 0.00% 37 Missing ⚠️
crates/bw/src/auth/mod.rs 0.00% 31 Missing ⚠️
crates/bw/src/command.rs 0.00% 11 Missing ⚠️
crates/bw/src/vault/mod.rs 0.00% 8 Missing ⚠️
crates/bw/src/platform/mod.rs 0.00% 2 Missing ⚠️
crates/bw/src/admin_console/mod.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
- Coverage   78.55%   78.15%   -0.40%     
==========================================
  Files         276      283       +7     
  Lines       27483    27611     +128     
==========================================
- Hits        21588    21579       -9     
- Misses       5895     6032     +137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dani-garcia dani-garcia marked this pull request as ready for review September 30, 2025 15:52
@dani-garcia dani-garcia requested a review from a team as a code owner September 30, 2025 15:52
@dani-garcia dani-garcia requested a review from coroiu September 30, 2025 15:52
coroiu
coroiu previously approved these changes Oct 1, 2025
# Conflicts:
#	crates/bw/src/main.rs
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 1, 2025

@dani-garcia dani-garcia requested a review from coroiu October 1, 2025 10:28
@dani-garcia dani-garcia merged commit 12fdb4d into main Oct 1, 2025
42 of 50 checks passed
@dani-garcia dani-garcia deleted the ps/cli-skeleton branch October 1, 2025 11:32
bw-ghapp bot pushed a commit to bitwarden/sdk-swift that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants