Skip to content

[PM-22593] improve initialization process for database and repositories #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

coroiu
Copy link
Contributor

@coroiu coroiu commented Jun 25, 2025

🎟️ Tracking

📔 Objective

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coroiu coroiu requested a review from dani-garcia June 25, 2025 13:08
Copy link
Contributor

github-actions bot commented Jun 25, 2025

Logo
Checkmarx One – Scan Summary & Details144c0a2f-9971-4f7b-9b2f-07f2c402d61c

Great job, no security vulnerabilities found in this Pull Request

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of small comments, otherwise lgtm

@coroiu coroiu requested a review from dani-garcia June 25, 2025 14:27
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 70.45%. Comparing base (5e9d57a) to head (7613452).
Report is 1 commits behind head on ps/state-impl.

Files with missing lines Patch % Lines
crates/bitwarden-state/src/sdk_managed/sqlite.rs 0.00% 10 Missing ⚠️
crates/bitwarden-uniffi/src/platform/mod.rs 0.00% 8 Missing ⚠️
crates/bitwarden-wasm-internal/src/platform/mod.rs 0.00% 7 Missing ⚠️
crates/bitwarden-core/src/platform/state_client.rs 0.00% 2 Missing ⚠️
crates/bitwarden-state/src/registry.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           ps/state-impl     #329      +/-   ##
=================================================
- Coverage          70.53%   70.45%   -0.09%     
=================================================
  Files                232      232              
  Lines              18808    18831      +23     
=================================================
  Hits               13267    13267              
- Misses              5541     5564      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@dani-garcia dani-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small non blocking thought about the sqlite separation

@coroiu coroiu marked this pull request as ready for review June 26, 2025 09:57
@coroiu coroiu requested a review from a team as a code owner June 26, 2025 09:57
@coroiu coroiu requested review from justindbaur and dani-garcia and removed request for justindbaur June 26, 2025 09:57
Copy link

@coroiu coroiu merged commit e5cab0d into ps/state-impl Jun 26, 2025
43 checks passed
@coroiu coroiu deleted the coroiu/PM-22593-improve-initialization-process-for-database-and-repositories branch June 26, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants