[PM-21691] - Added tree and test with implementation for CollectionView #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
jrmccannon
force-pushed
the
jmccannon/ac/pm-21691-nested-tree
branch
from
d1e534f to
b0dbb1c
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 73.43% 73.34% -0.10%
==========================================
Files 248 252 +4
Lines 20962 21283 +321
==========================================
+ Hits 15393 15609 +216
- Misses 5569 5674 +105 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coroiu
reviewed
May 28, 2025
Contributor
coroiu
left a comment
coroiu
left a comment
There was a problem hiding this comment.
Just some minor comments, but very nice overall, +1 for the tests 👍
Co-authored-by: Andreas Coroiu <acoroiu@bitwarden.com>
# Conflicts: # crates/bitwarden-vault/src/lib.rs
…dings to attempt to solve compile issue.
# Conflicts: # crates/bitwarden-collections/src/collection.rs
jrmccannon
changed the title
# Conflicts: # crates/bitwarden-collections/src/collection.rs
gbubemismith
previously approved these changes
Jul 25, 2025
Contributor
gbubemismith
left a comment
gbubemismith
left a comment
There was a problem hiding this comment.
Just one last comment
gbubemismith
approved these changes
Jul 28, 2025
justindbaur
approved these changes
Jul 28, 2025
|
quexten
added a commit
that referenced
this pull request
Aug 14, 2025
## 🎟️ Tracking https://bitwarden.slack.com/archives/C054ZQSBS49/p1755188403409309 ## 📔 Objective It seems #279 accidentally required wasm in all uniffi builds via `bitwarden-vault` -> `bitwarden-collections` -> `bitwarden-core`. Since it is only required on core, this leads to build issues on anything where an impl is tagged with wasm-bindgen, but uses a struct from a third package - such as `bitwarden-crypto` that does not have the wasm feature enabled. Attempts to fix the build errors of: #383 Note: This flags out a function from the collections client. This has to be fixed by the owning team and updated, this PR just unblocks builds and fixes the imports. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --------- Co-authored-by: Oscar Hinton <Hinton@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-21691
📔 Objective
This splits the collections code out of the vault crate and adds a Tree implementation for representing the parent child relationship between nested collections.
This ideally will then be used as a unified representation for the nested collection structure across all clients, instead of each one having to implement their own.
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes