Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

Change the icon baseline to 14% #637

Merged
merged 3 commits into from
Jan 27, 2022
Merged

Change the icon baseline to 14% #637

merged 3 commits into from
Jan 27, 2022

Conversation

Hinton
Copy link
Member

@Hinton Hinton commented Jan 27, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Changes the Bitwarden Icons baseline to 14% which is equal to what font awesome is. This resolves most of the icon misalignment except for the vault list icons.

While at it, I also removed vendor prefixed css since it's been ages since they were used.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@Hinton Hinton requested a review from vincentsalucci January 27, 2022 11:11
@Hinton Hinton merged commit 0186610 into master Jan 27, 2022
@Hinton Hinton deleted the hotfix/icons-baseline branch January 27, 2022 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants