Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

[bug] Set a default value for custom send deletion times in the safari extension #511

Merged
merged 2 commits into from
Oct 8, 2021
Merged

[bug] Set a default value for custom send deletion times in the safari extension #511

merged 2 commits into from
Oct 8, 2021

Conversation

addisonbeck
Copy link
Contributor

Related Work

Asana

Bug

Custom Send dates in Safari have a confusing UX. When the fields are initially displayed a placeholder is shown with today's date, but this can be confused as being a set in stone value for the field, and the required attribute doesn't work in the safari date picker polyfill in the browser extension[1], so we don't get good error handling explaining this.

Solution

Set a default value for custom send deletion times in the safari extension

Solution Demo

Screen.Recording.2021-10-08.at.10.16.55.AM.mov

@addisonbeck addisonbeck requested a review from a team October 8, 2021 14:24
cscharf
cscharf previously approved these changes Oct 8, 2021
View reviewed changes
cscharf
cscharf approved these changes Oct 8, 2021
View reviewed changes
Copy link
Contributor

@cscharf cscharf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better, thanks Addison!

@addisonbeck addisonbeck merged commit e69425c into master Oct 8, 2021
@addisonbeck addisonbeck deleted the SafariSendDateWoes branch October 8, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cscharf cscharf cscharf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@addisonbeck @cscharf