Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

[Set/Change Password] Update dependency chain #155

Merged
merged 1 commit into from
Aug 21, 2020
Merged

[Set/Change Password] Update dependency chain #155

merged 1 commit into from
Aug 21, 2020

Conversation

vincentsalucci
Copy link
Member

Objective

Update the dependency chain between change/set password super-classes in order to alleviate roadblocks for directory-connector.

Code Changes

  • change-password.component.ts: Removed unused dependencies
  • set-password.component.ts: Updated super-ctor dependency chain. Privatized necessary params.

@vincentsalucci vincentsalucci merged commit 6ab444a into master Aug 21, 2020
@vincentsalucci vincentsalucci deleted the m-dependency-chain branch August 21, 2020 17:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kspearrin kspearrin kspearrin approved these changes

@addisonbeck addisonbeck Awaiting requested review from addisonbeck

@cscharf cscharf Awaiting requested review from cscharf

@MattTheDev MattTheDev Awaiting requested review from MattTheDev

@mpbw2 mpbw2 Awaiting requested review from mpbw2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vincentsalucci @kspearrin