Upgrade Angular to 9 #151
Upgrade Angular to 9 #151
Conversation
Hinton
force-pushed
the
feature/upgrade-angular
branch
from
3765b72 to
ec86ac9
Compare
Hinton
force-pushed
the
feature/upgrade-angular
branch
from
ec86ac9 to
2866c6f
Compare
| @@ -6,6 +6,7 @@ import { | |||
| OnDestroy, | |||
| OnInit, | |||
| Output, | |||
| Directive, | |||
There was a problem hiding this comment.
linter should complain not alphabetial
There was a problem hiding this comment.
We seem to be missing the ordered-imports rule in tslint configs. I added the rule and ran lint:fix.
There was a problem hiding this comment.
After digging a bit, it seems that tslint:recommended has changed a bit between versions. Since it was updated during the TypeScript upgrade we got the new recommended rules.
Most if not all of the code formatting rules have been removed, palantir/tslint#4871. TSlint is now also deprecated with the recommendation to migrate over to ESlint and use Prettier for code formatting rules.
We can either re-add the removed rules or migrate to ESlint and Prettier.
package.json
Outdated
| }, | ||
| "dependencies": { | ||
| "@angular/animations": "7.2.1", | ||
| "@angular/animations": "9.1.12", | ||
| "@angular/cdk": "7.2.1", |
There was a problem hiding this comment.
Does this CDK need updating too?
Updated using
ng update.