This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Upgrade TypeScript #148
Merged
Upgrade TypeScript #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need to have a follow up PR in all repos that match this upgrade. |
kspearrin
reviewed
Aug 12, 2020
package.json
Outdated
| @@ -30,7 +30,7 @@ | |||
| "@types/jasmine": "^3.3.12", | |||
| "@types/lowdb": "^1.0.5", | |||
| "@types/lunr": "^2.3.3", | |||
| "@types/node": "^10.9.4", | |||
| "@types/node": "^12.12.54", | |||
There was a problem hiding this comment.
We still use node 10 for building our apps. Is this necessary?
There was a problem hiding this comment.
We get compile errors otherwise, I can try using a newer version of 10.
This was referenced Aug 12, 2020
kspearrin
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeScript 3.6+ is required to access newer versions of the navigator. apis.