This repository was archived by the owner on Jun 17, 2022. It is now read-only.
Misc jslib cleanups #146
Merged
Misc jslib cleanups #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kspearrin
suggested changes
Aug 11, 2020
src/abstractions/index.ts
Outdated
Comment on lines
4
to
10
| export { AuthService } from './auth.service'; | ||
| export { CipherService } from './cipher.service'; | ||
| export { CollectionService } from './collection.service'; | ||
| export { CryptoFunctionService } from './cryptoFunction.service'; | ||
| export { CryptoService } from './crypto.service'; | ||
| export { EnvironmentService } from './environment.service'; | ||
| export { FolderService } from './folder.service'; |
There was a problem hiding this comment.
I have not been using these index barrels for a while now and would actually like to do away with them completely. They create issues with importing dependencies on certain platforms.
There was a problem hiding this comment.
Nice, I think that's for the best. I added a deprecation warning to index.ts instead.
cscharf
approved these changes
Aug 11, 2020
kspearrin
approved these changes
Aug 11, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Changes
login.componentchanged variable
stateServiceto be of typeStateService()combined the abstractions imports into one group
abstractions/index.tsadded an export for
CryptoFunctionService