This repository was archived by the owner on Jun 17, 2022. It is now read-only.
[SSO] Login - added launchSsoBrowser method #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentsalucci
requested review from
kspearrin,
addisonbeck,
cscharf,
MattTheDev and
mpbw2
kspearrin
approved these changes
Aug 10, 2020
addisonbeck
reviewed
Aug 11, 2020
| @@ -37,7 +40,9 @@ export class LoginComponent implements OnInit { | |||
|
|
|||
| constructor(protected authService: AuthService, protected router: Router, | |||
| protected platformUtilsService: PlatformUtilsService, protected i18nService: I18nService, | |||
| private storageService: StorageService, protected stateService: StorageService) { } | |||
| protected stateService: StorageService, protected environmentService: EnvironmentService, | |||
There was a problem hiding this comment.
@vincentsalucci is this intended to be have two instances of a StorageService? Seems like it should be stateService: StateService ?
There was a problem hiding this comment.
I'm also wondering if the CryptoFunctionService needs to get added to the index.ts in the abstractions folder?
There was a problem hiding this comment.
( went ahead and threw together a PR for this stuff in case it is needed )
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Code Changes
launchSsoBrowsermethod. Cleaned up imports and adjusted constructor.