Skip to content

Conversation

@iinuwa
Copy link

@iinuwa iinuwa commented Jan 5, 2026

📔 Objective

This updates the cryptographic state initialization code based on updates to the SDK. #2190 is stacked on top of this.

I'm not sure if this is the correct way to provide these updates, so this is just a starting point. I'm also not sure how to point to the latest SDK in, so the Package.resolved change is definitely wrong.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

Logo
Checkmarx One – Scan Summary & Details36f89aeb-9cd8-4570-8862-44dd8e5fa978

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.58%. Comparing base (79c37d7) to head (967ca13).
⚠️ Report is 2 commits behind head on iinuwa/update-passkey-rs.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           iinuwa/update-passkey-rs    #2234       +/-   ##
=============================================================
- Coverage                     85.47%   43.58%   -41.89%     
=============================================================
  Files                          1746      584     -1162     
  Lines                        147479    30505   -116974     
=============================================================
- Hits                         126053    13295   -112758     
+ Misses                        21426    17210     -4216     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KatherineInCode
Copy link
Contributor

I'm also not sure how to point to the latest SDK

The version of the SDK used is specified in project-common.yml. The Package.resolved file is an echo of that, which would only be used for caching Swift packages on builds; though we've talked about ignoring it regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants