Skip to content

Conversation

@andrebispo5
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-29835

📔 Objective

Organizaion event tracking enhancements:

  • Added organizationItemOrganizationAccepted and organizationItemOrganizationDeclined cases to the EventType enum to support tracking when an organization item is accepted or declined.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copilot AI review requested due to automatic review settings December 23, 2025 11:41
@andrebispo5 andrebispo5 requested review from a team and matt-livefront as code owners December 23, 2025 11:41
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds two new event types to support tracking when organization items are accepted or declined during item migration. These event types integrate into the existing event tracking system used throughout the application.

  • Added organizationItemOrganizationAccepted and organizationItemOrganizationDeclined enum cases with values 1618 and 1619
  • Extended the organization event type range (1600 series) to include item migration tracking

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +50 to +51
case organizationItemOrganizationAccepted = 1618
case organizationItemOrganizationDeclined = 1619
Copy link

Copilot AI Dec 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The case names contain redundant "Organization" repetition. Following the existing naming patterns in this enum (e.g., organizationUserInvited, organizationUpdated, organizationPurgedVault), these should be named organizationItemAccepted and organizationItemDeclined instead of organizationItemOrganizationAccepted and organizationItemOrganizationDeclined. The extra "Organization" in the middle makes the names unnecessarily verbose and inconsistent with the established conventions.

Suggested change
case organizationItemOrganizationAccepted = 1618
case organizationItemOrganizationDeclined = 1619
case organizationItemAccepted = 1618
case organizationItemDeclined = 1619

Copilot uses AI. Check for mistakes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The naming is following the server name convention for consistency.

@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsd4cf09ad-717b-4228-81c3-235a6065c25c

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 23, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.47%. Comparing base (33da013) to head (6cc2431).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2214      +/-   ##
==========================================
- Coverage   85.47%   85.47%   -0.01%     
==========================================
  Files        1746     1746              
  Lines      147479   147479              
==========================================
- Hits       126059   126055       -4     
- Misses      21420    21424       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants