-
Notifications
You must be signed in to change notification settings - Fork 88
[PM-29835] Add org events for item migration #2214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds two new event types to support tracking when organization items are accepted or declined during item migration. These event types integrate into the existing event tracking system used throughout the application.
- Added
organizationItemOrganizationAcceptedandorganizationItemOrganizationDeclinedenum cases with values 1618 and 1619 - Extended the organization event type range (1600 series) to include item migration tracking
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case organizationItemOrganizationAccepted = 1618 | ||
| case organizationItemOrganizationDeclined = 1619 |
Copilot
AI
Dec 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The case names contain redundant "Organization" repetition. Following the existing naming patterns in this enum (e.g., organizationUserInvited, organizationUpdated, organizationPurgedVault), these should be named organizationItemAccepted and organizationItemDeclined instead of organizationItemOrganizationAccepted and organizationItemOrganizationDeclined. The extra "Organization" in the middle makes the names unnecessarily verbose and inconsistent with the established conventions.
| case organizationItemOrganizationAccepted = 1618 | |
| case organizationItemOrganizationDeclined = 1619 | |
| case organizationItemAccepted = 1618 | |
| case organizationItemDeclined = 1619 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The naming is following the server name convention for consistency.
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2214 +/- ##
==========================================
- Coverage 85.47% 85.47% -0.01%
==========================================
Files 1746 1746
Lines 147479 147479
==========================================
- Hits 126059 126055 -4
- Misses 21420 21424 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-29835
📔 Objective
Organizaion event tracking enhancements:
organizationItemOrganizationAcceptedandorganizationItemOrganizationDeclinedcases to theEventTypeenum to support tracking when an organization item is accepted or declined.⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes