Skip to content

Conversation

@andrebispo5
Copy link
Contributor

@andrebispo5 andrebispo5 commented Dec 12, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-28997

📔 Objective

This pull request introduces the initial implementation of the "Migrate to My Items" feature, which guides users through transferring ownership of vault items to their organization or leaving the organization if they decline. It includes new UI views, state management, processor logic, localized strings, and supporting assets.

These changes lay the groundwork for the "Migrate to My Items" feature, providing a interface and state-driven logic for handling organization item ownership policies.

📸 Screenshots

In the screenshots the organization name is missing, it will be added later on.

Simulator Screenshot - iPhone 17 Pro - 2025-12-12 at 11 05 24 Simulator Screenshot - iPhone 17 Pro - 2025-12-12 at 11 05 28 Simulator Screenshot - iPhone 16 Pro - 2025-12-12 at 10 56 27 Simulator Screenshot - iPhone 16 Pro - 2025-12-12 at 10 56 24

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2025

Logo
Checkmarx One – Scan Summary & Details984a76d1-2e5d-481e-9142-c5486c9ccf6a

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

❌ Patch coverage is 72.17391% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.30%. Comparing base (a39361e) to head (8584963).

Files with missing lines Patch % Lines
...t/MigrateToMyItems/MigrateToMyItemsProcessor.swift 0.00% 51 Missing ⚠️
...Platform/Application/Extensions/View+Toolbar.swift 50.00% 10 Missing ⚠️
.../Vault/MigrateToMyItems/MigrateToMyItemsView.swift 97.82% 2 Missing ⚠️
...Vault/MigrateToMyItems/MigrateToMyItemsState.swift 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2196      +/-   ##
==========================================
- Coverage   85.53%   84.30%   -1.24%     
==========================================
  Files        1737     1983     +246     
  Lines      147232   162592   +15360     
==========================================
+ Hits       125942   137067   +11125     
- Misses      21290    25525    +4235     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants