Skip to content

[PM-28029] Address SonarCloud and zizmor errors #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+1 −100
Open

[PM-28029] Address SonarCloud and zizmor errors #2124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3b58d19
Set default value for Patch when repo doesn't have a tag
vvolkgang Nov 10, 2025
16e0186
zizmor - Remove secrets:inherit from _version.yml calls
vvolkgang Nov 10, 2025
86619b4
Remove dispatch-and-download action
vvolkgang Nov 10, 2025
d89465a
Merge branch 'main' into vvolkgang/zizmor
vvolkgang Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 0 additions & 97 deletions .github/actions/dispatch-and-download/action.yml
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion .github/workflows/_version.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:

latest_tag_version=$(git tag -l --sort=-creatordate | grep "$APP_CODENAME" | head -n 1)
if [[ -z "$latest_tag_version" ]]; then
version_name="${current_year}.${current_month}.${_PATCH_VERSION}"
version_name="${current_year}.${current_month}.${_PATCH_VERSION:-0}"
Copy link

@claude claude bot Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good fix - the :-0 default prevents bash errors when _PATCH_VERSION is unset and no tags exist in the repository.

echo "::warning::No tags found, did you checkout? Calculating version from current date: $version_name"
output "$version_name"
exit 0
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-bwa.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ jobs:
version_name: ${{ inputs.version-name }}
version_number: ${{ inputs.version-number }}
patch_version: ${{ inputs.patch_version && '999' || '' }}
secrets: inherit

build-manual:
name: Build Manual - ${{ inputs.build-mode }}
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/ci-bwpm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,6 @@ jobs:
version_name: ${{ inputs.version-name }}
version_number: ${{ inputs.version-number }}
patch_version: ${{ inputs.patch_version && '999' || '' }}
secrets: inherit

build-manual:
name: Build Manual - ${{ inputs.build-variant }} (${{ inputs.build-mode }})
Expand Down
Loading