Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template usage #161

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Template usage #161

merged 1 commit into from
Jun 22, 2023

Conversation

withinfocus
Copy link
Contributor

@withinfocus withinfocus commented Jun 21, 2023

๐ŸŽŸ๏ธ Tracking

Internal change.

๐Ÿšง Type of change

  • ๐Ÿงน Tech debt (refactoring, code cleanup, dependency upgrades, etc.)
  • ๐Ÿค– Build/deploy pipeline (DevOps)

๐Ÿ“” Objective

Applies all the setup from the template repository.

๐Ÿ“‹ Code changes

  • .editorconfig: Editor configuration used by multiple systems.
  • .gitattributes: File ending settings.
  • .github/CODEOWNERS: Specifying final ownership by DevOps for the repo (template customization).
  • .github/PULL_REQUEST_TEMPLATE.md: This template!
  • .github/dependabot.yml: Remove Dependabot usage for dependencies.
  • .gitignore: Standard ignores along with what was already present.
  • .husky/pre-commit: Staged linting via NPM.
  • Markdown and text files: Boilerplate for licensing and our standards. Cleaned up the README.md a bit.
  • package.json: ... with lockfile. After an installation, utilizes Prettier on all files via staged linting.

โฐ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation or informed the documentation team

๐Ÿฆฎ Reviewer guidelines

  • ๐Ÿ‘ (:+1:) or similar for great changes
  • ๐Ÿ“ (:memo:) or โ„น๏ธ (:information_source:) for notes or general info
  • โ“ (:question:) for questions
  • ๐Ÿค” (:thinking:) or ๐Ÿ’ญ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • ๐ŸŽจ (:art:) for suggestions / improvements
  • โŒ (:x:) or โš ๏ธ (:warning:) for more significant problems or concerns needing attention
  • ๐ŸŒฑ (:seedling:) or โ™ป๏ธ (:recycle:) for future improvements or indications of technical debt
  • โ› (:pick:) for minor or nitpick changes

@withinfocus withinfocus requested a review from a team June 21, 2023 21:51
@withinfocus withinfocus marked this pull request as ready for review June 21, 2023 21:51
@withinfocus withinfocus merged commit 6198e95 into master Jun 22, 2023
@withinfocus withinfocus deleted the cleanup branch June 22, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants