Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PM-4871] Increase click area of checkbox on vault item list #7860

Closed
wants to merge 3 commits into from
Closed

[PM-4871] Increase click area of checkbox on vault item list #7860

wants to merge 3 commits into from

Conversation

gbubemismith
Copy link
Member

Type of change

- [ ] Bug fix
- [ ] New feature development
- [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

PR to build artifacts for #6911

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@gbubemismith gbubemismith requested a review from a team as a code owner February 8, 2024 18:01
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Feb 8, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (304c492) 58.83% compared to head (1196f4b) 59.23%.
Report is 61 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #7860      +/-   ##
==========================================
+ Coverage   58.83%   59.23%   +0.39%     
==========================================
  Files        1033     1052      +19     
  Lines       26766    27146     +380     
  Branches     5350     5430      +80     
==========================================
+ Hits        15749    16079     +330     
- Misses       9713     9741      +28     
- Partials     1304     1326      +22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitwarden-bot
Copy link

bitwarden-bot commented Feb 8, 2024 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 888f6987-adfb-42de-88f0-d81b3f405b0e

New Issues

Severity Issue Source File / Package Checkmarx Insight
HIGH Client_DOM_XSS /apps/browser/src/platform/browser/browser-api.spec.ts: 189 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 176 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 175 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 174 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 181 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 255 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 86 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 262 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 93 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 87 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 256 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 88 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 254 Attack Vector
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1163 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 432 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 280 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 378 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 299 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 204 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-browser.yml: 370 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1242 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-cli.yml: 408 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-web.yml: 310 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
LOW Client_DOM_Open_Redirect /apps/browser/src/platform/browser/browser-api.spec.ts: 190 Attack Vector
LOW Client_DOM_Open_Redirect /apps/browser/src/platform/browser/browser-api.spec.ts: 189 Attack Vector
LOW Client_Password_In_Comment /libs/importer/spec/test-data/roboform-csv/with-folders.ts: 2 Attack Vector
LOW Client_Password_In_Comment /libs/importer/spec/test-data/roboform-csv/empty-folders.ts: 2 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/exporter/src/vault-export/services/individual-vault-export.service.spec.ts: 208 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/exporter/src/vault-export/services/individual-vault-export.service.spec.ts: 208 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/exporter/src/vault-export/services/individual-vault-export.service.spec.ts: 208 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 187 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 176 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 168 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 163 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 155 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 139 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 187 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 176 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 168 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 163 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 155 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/key-rotation/user-key-rotation.service.spec.ts: 139 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 176 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 176 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 175 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 174 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 174 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3654 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3690 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3700 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3699 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3701 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 3672 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/admin-console/organizations/members/services/organization-user-reset-password/organization-user-reset-password.service.spec.ts: 108 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/admin-console/organizations/members/services/organization-user-reset-password/organization-user-reset-password.service.spec.ts: 108 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/dom-element-visibility.service.spec.ts: 161 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill.service.spec.ts: 1316 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill-overlay-content.service.spec.ts: 1012 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill-overlay-content.service.spec.ts: 1025 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/background/overlay.background.spec.ts: 623 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/autofill-overlay-content.service.spec.ts: 1037 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/background/overlay.background.spec.ts: 854 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/background/overlay.background.spec.ts: 857 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/spec/securesafe-csv-importer.spec.ts: 41 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/importer/spec/securesafe-csv-importer.spec.ts: 20 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/emergency-access/services/emergency-access.service.spec.ts: 144 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/web/src/app/auth/emergency-access/services/emergency-access.service.spec.ts: 144 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/common/src/vault/models/domain/login.spec.ts: 80 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/login.strategy.spec.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/password-login.strategy.spec.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/browser/main-context-menu-handler.spec.ts: 94 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 256 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 86 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 88 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 255 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 256 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 255 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 254 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 256 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 256 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 86 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 88 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 87 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 254 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 254 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/login.strategy.spec.ts: 71 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/login.strategy.spec.ts: 57 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/login.strategy.spec.ts: 45 Attack Vector
LOW Use_Of_Hardcoded_Password /libs/auth/src/common/login-strategies/password-login.strategy.spec.ts: 204 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 38 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 54 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 40 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 46 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 51 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 31 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 34 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 34 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/jest/autofill-mocks.ts: 35 Attack Vector
LOW Use_Of_Hardcoded_Password /apps/browser/src/autofill/services/collect-autofill-content.service.spec.ts: 754

More results are available on AST platform

@gbubemismith gbubemismith removed the needs-qa Marks a PR as requiring QA approval label Feb 14, 2024
@gbubemismith gbubemismith deleted the community/PM-4871/checkbox-ux branch February 14, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shane-melton shane-melton Awaiting requested review from shane-melton shane-melton is a code owner automatically assigned from bitwarden/team-vault-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbubemismith @bitwarden-bot @Spitfireap