Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AC-1873] Only assign user in the front-end if using Flexible Collections #7051

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Nov 30, 2023

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Restore previous behaviour when creating a new collection:

  • front-end - no users are added by default
  • server - if you're a Manager or have EditAssignedCollections permission, you're assigned to the collection on creation

The server PR is bitwarden/server#3498.

Code changes

  • only add the current user on the front-end if flexible collections is ON.
  • in that case, we add them with Can Manage permissions, per the new flexible collections permission system.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Detailse6606c66-5192-4dc5-b004-baf75c9f92ad

No New Or Fixed Issues Found

@vincentsalucci vincentsalucci added bug and removed needs-qa Marks a PR as requiring QA approval labels Dec 1, 2023
@vincentsalucci vincentsalucci merged commit 0d035c5 into master Dec 1, 2023
31 of 33 checks passed
@vincentsalucci vincentsalucci deleted the ac/ac-1873/defect-member-is-auto-assigned-can-edit-permission-during-collection-creation branch December 1, 2023 15:45
vincentsalucci pushed a commit that referenced this pull request Dec 1, 2023
…ions (#7051)

* Only assign user in the front-end if using Flexible Collections

* Fix prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants