Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1873] Only assign user in the front-end if using Flexible Collections #7051

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[AC-1873] Only assign user in the front-end if using Flexible Collections #7051

merged 2 commits into from
Dec 1, 2023

Conversation

eliykat
Copy link
Member

@eliykat eliykat commented Nov 30, 2023 •
edited
Loading

Type of change

- [ ] Bug fix
- [ ] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Restore previous behaviour when creating a new collection:

  • front-end - no users are added by default
  • server - if you're a Manager or have EditAssignedCollections permission, you're assigned to the collection on creation

The server PR is bitwarden/server#3498.

Code changes

  • only add the current user on the front-end if flexible collections is ON.
  • in that case, we add them with Can Manage permissions, per the new flexible collections permission system.

Screenshots

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Nov 30, 2023
@eliykat eliykat mentioned this pull request Dec 1, 2023
Merged
@eliykat eliykat marked this pull request as ready for review December 1, 2023 00:22
@eliykat eliykat requested a review from a team as a code owner December 1, 2023 00:22
@eliykat eliykat mentioned this pull request Dec 1, 2023
Closed
@bitwarden-bot
Copy link

Logo
Checkmarx One – Scan Summary & Details – e6606c66-5192-4dc5-b004-baf75c9f92ad

No New Or Fixed Issues Found

@vincentsalucci vincentsalucci added bug and removed needs-qa Marks a PR as requiring QA approval labels Dec 1, 2023
@vincentsalucci vincentsalucci merged commit 0d035c5 into master Dec 1, 2023
31 of 33 checks passed
@vincentsalucci vincentsalucci deleted the ac/ac-1873/defect-member-is-auto-assigned-can-edit-permission-during-collection-creation branch December 1, 2023 15:45
vincentsalucci pushed a commit that referenced this pull request Dec 1, 2023
@eliykat @vincentsalucci
[AC-1873] Only assign user in the front-end if using Flexible Collect…
aafda15 
…ions (#7051)

* Only assign user in the front-end if using Flexible Collections

* Fix prettier
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shane-melton shane-melton shane-melton approved these changes

@vincentsalucci vincentsalucci vincentsalucci approved these changes

@gbubemismith gbubemismith Awaiting requested review from gbubemismith gbubemismith was automatically assigned from bitwarden/team-vault-dev

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eliykat @bitwarden-bot @shane-melton @vincentsalucci