Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-4871] Remove clickable row in favor of clickable cell content #6911

Merged
merged 3 commits into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Component, EventEmitter, HostBinding, HostListener, Input, Output } from "@angular/core";
import { ActivatedRoute, Router } from "@angular/router";
import { Component, EventEmitter, Input, Output } from "@angular/core";

import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
import { CipherType } from "@bitwarden/common/vault/enums";
Expand Down Expand Up @@ -35,16 +34,6 @@ export class VaultCipherRowComponent {

protected CipherType = CipherType;

constructor(
private router: Router,
private activatedRoute: ActivatedRoute,
) {}

@HostBinding("class")
get classes() {
return [].concat(this.disabled ? [] : ["tw-cursor-pointer"]);
}

protected get showTotpCopyButton() {
return (
(this.cipher.login?.hasTotp ?? false) &&
Expand All @@ -56,16 +45,6 @@ export class VaultCipherRowComponent {
return this.cipher.hasOldAttachments && this.cipher.organizationId == null;
}

@HostListener("click")
protected click() {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate([], {
queryParams: { itemId: this.cipher.id },
queryParamsHandling: "merge",
});
}

protected copy(field: "username" | "password" | "totp") {
this.onEvent.emit({ type: "copyField", item: this.cipher, field });
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { Component, EventEmitter, HostBinding, HostListener, Input, Output } from "@angular/core";
import { Router } from "@angular/router";
import { Component, EventEmitter, Input, Output } from "@angular/core";

import { Organization } from "@bitwarden/common/admin-console/models/domain/organization";
import { I18nService } from "@bitwarden/common/platform/abstractions/i18n.service";
Expand Down Expand Up @@ -38,15 +37,7 @@ export class VaultCollectionRowComponent {
@Input() checked: boolean;
@Output() checkedToggled = new EventEmitter<void>();

constructor(
private router: Router,
private i18nService: I18nService,
) {}

@HostBinding("class")
get classes() {
return [].concat(this.disabled ? [] : ["tw-cursor-pointer"]);
}
constructor(private i18nService: I18nService) {}

get collectionGroups() {
if (!(this.collection instanceof CollectionAdminView)) {
Expand All @@ -71,16 +62,6 @@ export class VaultCollectionRowComponent {
}
}

@HostListener("click")
protected click() {
// FIXME: Verify that this floating promise is intentional. If it is, add an explanatory comment and ensure there is proper error handling.
// eslint-disable-next-line @typescript-eslint/no-floating-promises
this.router.navigate([], {
queryParams: { collectionId: this.collection.id },
queryParamsHandling: "merge",
});
}

protected edit() {
this.onEvent.next({ type: "editCollection", item: this.collection });
}
Expand Down
Loading