Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AC-1435] Copy updates for Single Organization policy prerequisite for Account Recovery policy #5774

Merged
merged 6 commits into from
Jul 18, 2023
Merged

[AC-1435] Copy updates for Single Organization policy prerequisite for Account Recovery policy #5774

merged 6 commits into from
Jul 18, 2023

Conversation

shane-melton
Copy link
Member

Type of change

- [ ] Bug fix
- [X] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Update language related to Single Organization policy requirement for the Account Recovery policy and, by extension, Trusted Device Encryption.

See related server changes that enforce requirements: bitwarden/server#3082

Code changes

  • reset-password.component.html:
    • Update to CL components
    • Update callouts to match Figma design / copy
    • Remove auto-enroll header/description
  • reset-password.component.ts:
    • Update policy description
    • Switched to typed FormBuilder
  • sso.component.html:
    • Update copy to include separate link/reference to the Single Organization policy

Screenshots

Account Recovery Administration Policy Description Change

image

Account Recovery Administration Policy Modal Change

image

SSO TDE Option Description Change

image

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

@shane-melton shane-melton requested review from a team as code owners July 10, 2023 20:41
@github-actions github-actions bot added the needs-qa Marks a PR as requiring QA approval label Jul 10, 2023
@shane-melton shane-melton mentioned this pull request Jul 10, 2023
Merged
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great from an Auth / Trusted Device Encryption perspective! I pulled down the client and server and tested turning the relevant policies on / off + TDE on / off, and it all functioned as expected!

@bitwarden-bot
Copy link

bitwarden-bot commented Jul 10, 2023 •
edited
Loading

Logo
Checkmarx One – Scan Summary & Details – 315fc535-4af5-4857-9127-96e708226031

No New Or Fixed Issues Found

@djsmith85 djsmith85 mentioned this pull request Jul 11, 2023
Merged
djsmith85
djsmith85 reviewed Jul 11, 2023
View reviewed changes
Copy link
Contributor

@djsmith85 djsmith85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5790 to resolve the issue of bitwarden_license/bit-web/src/app/auth/* not having a codeowner.

@shane-melton shane-melton requested a review from a team as a code owner July 11, 2023 20:39
JaredSnider-Bitwarden
JaredSnider-Bitwarden previously approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

vincentsalucci
vincentsalucci previously approved these changes Jul 11, 2023
View reviewed changes
@vincentsalucci vincentsalucci dismissed stale reviews from JaredSnider-Bitwarden and themself via 43c0b65 July 17, 2023 22:31
JaredSnider-Bitwarden
JaredSnider-Bitwarden approved these changes Jul 17, 2023
View reviewed changes
Copy link
Contributor

@JaredSnider-Bitwarden JaredSnider-Bitwarden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vincentsalucci
Copy link
Member

@JaredSnider-Bitwarden @djsmith85 - Had to fix a typo pointed out by QA during testing. I updated the message key to make sure there are no issues with Crowd In.

@vincentsalucci vincentsalucci removed the needs-qa Marks a PR as requiring QA approval label Jul 18, 2023
@vincentsalucci vincentsalucci merged commit 9d8f52e into master Jul 18, 2023
23 of 24 checks passed
@vincentsalucci vincentsalucci deleted the ac/ac-1435/single-org-pre-req branch July 18, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djsmith85 djsmith85 djsmith85 approved these changes

@vincentsalucci vincentsalucci vincentsalucci approved these changes

@JaredSnider-Bitwarden JaredSnider-Bitwarden JaredSnider-Bitwarden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@shane-melton @bitwarden-bot @vincentsalucci @djsmith85 @JaredSnider-Bitwarden