-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS-2367] CLI pkg ref for argon2 lib #4579
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The dependency should be added to the package.json
in apps/cli
. Pkg should figure it out from there.
@Hinton I made the change, but it doesn't appear to work in my tests. |
@kspearrin that's odd. I did test it locally but I forgot to move the executable and after moving I get the same error. According to the docs it should pick it up https://github.com/vercel/pkg#native-addons. Maybe we need the assets but I was certain we had other native dependencies so it feels a bit odd needing an exception for this package. We'll want to make certain the correct node is distributed in each build. We do still need the argon2 in the |
Should be good to go now @Hinton. @bitwarden/dept-devops is exploring what we need to do to support the argon2.node binary on different OSs during the CI build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Package changes looks good. I'll let devops review the workflow changes.
https://bitwarden.atlassian.net/browse/DEVOPS-1182
Type of change
Objective
Fix reference to argon2 lib for CLI packaging.
Code changes
node_modules
to assets.Before you submit