[PM-30845] fix(vault): preserve card brand when editing existing card #18381
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your contribution! We've added this to our internal tracking system for review. Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process. |
bitwarden-bot
changed the title
jengstrom-bw
requested changes
Jan 26, 2026
Contributor
jengstrom-bw
left a comment
jengstrom-bw
left a comment
There was a problem hiding this comment.
@VedantMadane I added a comment on your change to card-details-section.component.ts that should get things working
libs/vault/src/cipher-form/components/card-details-section/card-details-section.component.ts
Show resolved
Hide resolved
VedantMadane
added a commit
to VedantMadane/clients
that referenced
this pull request
Feb 1, 2026
Addresses review feedback from @jengstrom-bw in PR bitwarden#18381. The brand field was being used in card-details-section.component.ts but wasn't defined in the OptionalInitialValues type, causing a TypeScript compilation error. Adds brand?: string; to the Credit Card Information section of OptionalInitialValues in cipher-form-config.service.ts.
jengstrom-bw
previously approved these changes
Feb 3, 2026
Contributor
jengstrom-bw
left a comment
jengstrom-bw
left a comment
There was a problem hiding this comment.
Thanks for making that change. Looks good!
Contributor
|
@VedantMadane I've moved this PR to QA for testing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #18381 +/- ##
=======================================
Coverage 43.43% 43.43%
=======================================
Files 3689 3689
Lines 108247 108248 +1
Branches 16374 16375 +1
=======================================
+ Hits 47014 47016 +2
Misses 59252 59252
+ Partials 1981 1980 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
VedantMadane
force-pushed
the
fix/card-brand-lost-on-re-edit
branch
from
0d895e7 to
646c05c
Compare
VedantMadane
requested review from
addisonbeck,
blackwood,
enmande,
mzieniukbw,
r-tome and
willmartian
VedantMadane
added a commit
to VedantMadane/clients
that referenced
this pull request
Feb 4, 2026
Addresses review feedback from @jengstrom-bw in PR bitwarden#18381. The brand field was being used in card-details-section.component.ts but wasn't defined in the OptionalInitialValues type, causing a TypeScript compilation error. Adds brand?: string; to the Credit Card Information section of OptionalInitialValues in cipher-form-config.service.ts.
Fixes bitwarden#16978 The brand field was not being restored when editing an existing card cipher, causing it to show '--Select--' and potentially lose the brand data when saving. Added the brand field to initFromExistingCipher() to properly restore the card brand when opening a card for editing. Also updated the test to verify all card fields including brand, expMonth, and expYear are properly initialized from existing cipher data.
Addresses review feedback from @jengstrom-bw in PR bitwarden#18381. The brand field was being used in card-details-section.component.ts but wasn't defined in the OptionalInitialValues type, causing a TypeScript compilation error. Adds brand?: string; to the Credit Card Information section of OptionalInitialValues in cipher-form-config.service.ts.
VedantMadane
force-pushed
the
fix/card-brand-lost-on-re-edit
branch
from
646c05c to
8bd20ae
Compare
VedantMadane
force-pushed
the
fix/card-brand-lost-on-re-edit
branch
from
8bd20ae to
bf35bad
Compare
djsmith85
requested review from
jengstrom-bw
and removed request for
a team,
addisonbeck,
blackwood,
enmande,
mzieniukbw,
nikwithak,
r-tome and
willmartian
jengstrom-bw
approved these changes
Feb 4, 2026
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking
Fixes #16978
Objective
When editing an existing card cipher, the brand field was not being restored, causing it to show '--Select--' instead of the saved brand value. If the user saves the card in this state, the brand information is lost.
Reminders before review
Changeset
Root cause
In \card-details-section.component.ts, the \initFromExistingCipher()\ method was missing the \�rand\ field when patching the form values.
Fix
Added the \�rand\ field to \initFromExistingCipher()\ to properly restore the card brand when opening a card for editing.
Testing
Updated the test \initializes cardDetailsForm from getInitialCipherValue\ to verify all card fields including brand, expMonth, and expYear are properly initialized from existing cipher data.
Security
No security implications - this is a data preservation fix.
Checklist