[majiayu000]

Summary

• Remove BadgeLogo.png to prevent Bitwarden from appearing as lock screen status app
• The new client no longer supports Windows 10/11 live tiles

Fixes #16746

Test plan

• Build AppX package after this change
• Verify Bitwarden no longer appears in Windows Settings > Personalization > Lock screen status

[CLAassistant]

All committers have signed the CLA.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-30268
Link: https://bitwarden.atlassian.net/browse/PM-30268

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[djsmith85]

@iinuwa: You recently did some work around the appx builds and also introduced custom-appx-manifest.xml which also lists the BadgeLogo along with <uap:LockScreen Notification="badgeAndTileText" BadgeLogo="assets\BadgeLogo.png" />. That line is what is called out as the root issue on the linked ticket. Albeit the custom-appx-manifest.xml currently not in use as that got temporarily reverted, from what I understand.

Any thoughts on this PR? Any experience with the LockScreen tiles?

[iinuwa]

@djsmith85 I'm not sure of all the implications of removing the Lock Screen status are (though it seems like a good idea to me). This PR would solve that problem correctly. If we move forward with this, the <uap:LockScreen> element should also be updated in custom-appx-manifest.xml (see below).

Albeit the custom-appx-manifest.xml currently not in use as that got temporarily reverted, from what I understand.

Correct, that manifest is currently only used locally for cross-compiled builds. We will have to start using the custom manifest when the native passkey plugin is released, so custom-appx-manifest.xml should also be updated to remove the lock screen configuration to keep it in sync with what electron-builder produces so that this does not regress.

[djsmith85]

Hi @majiayu000 and thank you for your contribution ❤️

Could you please merge the latest from main and update/remove the line in custom-appx-manifest.xml.

Once that is done, the resulting build artifact can be tested.

[majiayu000]

Updated: merged the latest main and removed the LockScreen configuration from apps/desktop/custom-appx-manifest.xml to keep it in sync with the generated AppX manifest.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.09%. Comparing base (3213690) to head (d735df9).
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18137      +/-   ##
==========================================
- Coverage   47.10%   47.09%   -0.01%     
==========================================
  Files        3948     3948              
  Lines      119688   119688              
  Branches    18344    18344              
==========================================
- Hits        56374    56373       -1     
- Misses      59080    59081       +1     
  Partials     4234     4234              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud