-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[PM-24377] Use PureCrypto for decryptUserKeyWithMasterKey on the master password service
#16522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Thomas-Avery while this is ready to be reviewed, it's dependent on bitwarden/sdk-internal#465, which means GH Actions will fail. |
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16522 +/- ##
=======================================
Coverage 39.20% 39.20%
=======================================
Files 3463 3463
Lines 98126 98112 -14
Branches 14736 14733 -3
=======================================
- Hits 38469 38464 -5
+ Misses 57991 57985 -6
+ Partials 1666 1663 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Thomas-Avery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor thing to look at for the tests.
libs/common/src/key-management/master-password/services/master-password.service.spec.ts
Outdated
Show resolved
Hide resolved
Thomas-Avery
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |




🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-24377
📔 Objective
Uses new SDK method
PureCrypto.decrypt_user_key_with_master_keybeing introduced in bitwarden/sdk-internal#465, to decrypt UserKey with MasterKey.This is to isolate type 0 decryption to just go through an isolated SDK code path.
Note currently key connector and master password login go through this code path and should be the focus.
📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes