Skip to content

Conversation

@mzieniukbw
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-24377

📔 Objective

Uses new SDK method PureCrypto.decrypt_user_key_with_master_key being introduced in bitwarden/sdk-internal#465, to decrypt UserKey with MasterKey.

This is to isolate type 0 decryption to just go through an isolated SDK code path.
Note currently key connector and master password login go through this code path and should be the focus.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@mzieniukbw mzieniukbw requested a review from a team as a code owner September 21, 2025 22:58
@mzieniukbw
Copy link
Contributor Author

@Thomas-Avery while this is ready to be reviewed, it's dependent on bitwarden/sdk-internal#465, which means GH Actions will fail.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2025

Logo
Checkmarx One – Scan Summary & Details5c1eb40d-fd69-4655-9887-99c187f59f97

Great job! No new security vulnerabilities introduced in this pull request

@codecov
Copy link

codecov bot commented Sep 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 39.20%. Comparing base (d65824e) to head (66b83d6).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16522   +/-   ##
=======================================
  Coverage   39.20%   39.20%           
=======================================
  Files        3463     3463           
  Lines       98126    98112   -14     
  Branches    14736    14733    -3     
=======================================
- Hits        38469    38464    -5     
+ Misses      57991    57985    -6     
+ Partials     1666     1663    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor thing to look at for the tests.

Thomas-Avery
Thomas-Avery previously approved these changes Sep 30, 2025
Copy link
Contributor

@Thomas-Avery Thomas-Avery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

@mzieniukbw mzieniukbw merged commit 8f0d509 into main Oct 17, 2025
114 checks passed
@mzieniukbw mzieniukbw deleted the km/pm-24377 branch October 17, 2025 17:28
@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 17, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and all feature flags disabled.

✅ Fortunately, these BIT tests have passed! 🎉

@bw-ghapp
Copy link
Contributor

bw-ghapp bot commented Oct 17, 2025

Changes in this PR impact the Autofill experience of the browser client

BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.

✅ Fortunately, these BIT tests have passed! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants