[PM-24243] Load config service feature flag into SDK client #15855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
addisonbeck
previously approved these changes
Jul 31, 2025
shane-melton
added a commit
to bitwarden/sdk-internal
that referenced
this pull request
Aug 5, 2025
## 🎟️ Tracking [PM-24243](https://bitwarden.atlassian.net/browse/PM-24243) ## 📔 Objective Add `load_flags` method to the wasm `PlatformClient` to match parity with the uniffi `PlatformClient` so that the TS clients can set the SDK flags dynamically. Related Clients PR: bitwarden/clients#15855 ~Added a `FlagsInput` struct that mimics the internal `Flags` struct but with tsify bindings.~ ~Another potential option is to make the internal `Flags` struct public with wasm bindings to avoid duplicating the struct.~ ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes [PM-24243]: https://bitwarden.atlassian.net/browse/PM-24243?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15855 +/- ##
==========================================
- Coverage 37.31% 37.31% -0.01%
==========================================
Files 3348 3348
Lines 95120 95130 +10
Branches 14384 14385 +1
==========================================
- Hits 35495 35493 -2
- Misses 58055 58066 +11
- Partials 1570 1571 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
addisonbeck
previously approved these changes
Aug 21, 2025
Member
Author
|
@addisonbeck Sorry to ping again, had to resolve a merge conflict |
addisonbeck
previously approved these changes
Sep 3, 2025
|
Contributor
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and all feature flags disabled. ✅ Fortunately, these BIT tests have passed! 🎉 |
Contributor
Changes in this PR impact the Autofill experience of the browser clientBIT has tested the core experience with these changes and the feature flag configuration used by ✅ Fortunately, these BIT tests have passed! 🎉 |
addisonbeck
approved these changes
Sep 3, 2025
vlad-trofimov
pushed a commit
to vlad-trofimov/clients
that referenced
this pull request
Sep 30, 2025
…n#15855) * [PM-24243] Load config service feature flag into SDK client during initialization * [PM-24243] Bump sdk version * [PM-24243] Update load_flags to use generic Map instead of strongly typed object * [PM-24243] Pass entire feature states object into SDK * [PM-24243] Bump SDK version * [PM-24243] Fix failing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-24243
📔 Objective
When creating an SDK client, use a new
load_flagsmethod on the platform client to initialize the SDK client flags. Necessary so that the SDK will only use cipher key encryption when the LD feature flag is enabled.Requires bitwarden/sdk-internal#369 - Merged!Previous SDK PR was reverted in favor of bitwarden/sdk-internal#378 which updates the load_flags method to accept a map instead of strongly typed enum/record.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes