[PM-17913] fix: zh-TW registerLocaleData missing extra error

[nick411077]

🎟️ Tracking

#12933
#6821
#5220

📔 Objective

Fix zh-TW time format requires extra Day Periods.

I looked at angular/angular#54114 where they talked about Unable to find zh-Hant-TW, but bitwarden uses zh-Hant so it doesn't affect the usage.

what we encountered is the locale DatePipe error.
The default time format of CLDR zh-Hant is Bh uses Day Periods.
Angular places Day Periods in the extra folder.

Use translation, which may not be grammatically correct🙇

📸 Screenshots

desktop

web

browser

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal tracking system for review.
ID: PM-17913
Link: https://bitwarden.atlassian.net/browse/PM-17913

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[github-actions]

Checkmarx One – Scan Summary & Details – f6ba1c7c-ed44-4af6-85d1-f754436d2a44

New Issues (9)

Checkmarx found the following issues in this Pull Request

Severity	Issue	Source File / Package	Checkmarx Insight
	Angular_Improper_Type_Pipe_Usage	/libs/components/src/navigation/nav-divider.component.html: 1	details The value used in open$ at /libs/components/src/navigation/nav-divider.component.html in line 1 may throw an exception with the pipe open$ in /libs... Attack Vector
	Client_Privacy_Violation	/libs/tools/generator/components/src/credential-generator-history.component.html: 3	details Method at line 3 of /libs/tools/generator/components/src/credential-generator-history.component.html sends user information outside the applicatio... Attack Vector
	Client_Privacy_Violation	/libs/tools/generator/components/src/username-generator.component.html: 3	details Method at line 3 of /libs/tools/generator/components/src/username-generator.component.html sends user information outside the application. This ma... Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/tools/password-generator-history.component.html: 11	details Method at line 11 of /apps/web/src/app/tools/password-generator-history.component.html sends user information outside the application. This may co... Attack Vector
	Client_Privacy_Violation	/libs/vault/src/components/password-history-view/password-history-view.component.html: 6	details Method at line 6 of /libs/vault/src/components/password-history-view/password-history-view.component.html sends user information outside the appli... Attack Vector
	Client_Privacy_Violation	/libs/vault/src/components/password-history-view/password-history-view.component.html: 6	details Method at line 6 of /libs/vault/src/components/password-history-view/password-history-view.component.html sends user information outside the appli... Attack Vector
	Client_Privacy_Violation	/apps/web/src/app/tools/password-generator-history.component.html: 11	details Method at line 11 of /apps/web/src/app/tools/password-generator-history.component.html sends user information outside the application. This may co... Attack Vector
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 17	details Method Lambda at line 17 of /libs/components/src/color-password/color-password.component.ts sends user information outside the application. This ma... Attack Vector
	Client_Privacy_Violation	/libs/components/src/color-password/color-password.component.ts: 31	details Method at line 31 of /libs/components/src/color-password/color-password.component.ts sends user information outside the application. This may cons... Attack Vector

Fixed Issues (2)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	CVE-2024-21538	Npm-cross-spawn-7.0.3
	CVE-2024-55565	Npm-nanoid-3.3.7

[codecov]

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.48%. Comparing base (1d71212) to head (7150277).
Report is 29 commits behind head on main.

Files with missing lines	Patch %	Lines
apps/browser/src/platform/popup/locales.ts	0.00%	2 Missing ⚠️
apps/desktop/src/platform/app/locales.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13210      +/-   ##
==========================================
- Coverage   35.48%   35.48%   -0.01%     
==========================================
  Files        3007     3007              
  Lines       90899    90904       +5     
  Branches    16908    16908              
==========================================
+ Hits        32260    32261       +1     
- Misses      56137    56141       +4     
  Partials     2502     2502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.