Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17628] Rename @bitwarden/importer/core to @bitwarden/importer-core #13182

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17628

📔 Objective

To be in line with npm package naming guidelines this renames @bitwarden/importer/core to @bitwarden/importer-core

Within a future PR the libs/importer-folder will be broken up into two "packages" similar as vault-export or key-management.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested review from a team as code owners January 31, 2025 16:03
@djsmith85 djsmith85 requested review from coroiu and BTreston January 31, 2025 16:03
@djsmith85 djsmith85 enabled auto-merge (squash) January 31, 2025 16:03
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details3ab68ad6-09a8-42b0-b8fe-013aa201edfc

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 35.49%. Comparing base (4936e6a) to head (b585d99).

Files with missing lines Patch % Lines
...ole/organizations/settings/org-import.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13182      +/-   ##
==========================================
- Coverage   35.50%   35.49%   -0.01%     
==========================================
  Files        3007     3007              
  Lines       90887    90887              
  Branches    16906    16906              
==========================================
- Hits        32267    32260       -7     
- Misses      56118    56125       +7     
  Partials     2502     2502              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@coroiu coroiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving platform changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants