Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth/pm 8115/desktop extension UI refresh self hosted #11597

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

alec-livefront
Copy link
Collaborator

@alec-livefront alec-livefront commented Oct 17, 2024

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8115?atlOrigin=eyJpIjoiZjYxZDhiNjg1OWQwNDFlZGI3NWQyYmVkYTZlMGVhNGYiLCJwIjoiaiJ9

📔 Objective

Uses the new RegistrationSelfHostedEnvConfigDialogComponent as the dialog when selecting "self-hosted" from the server configuration on the login page. Also adjusts the leading text for the select based on whether the UnauthenticatedExtensionUIRefresh is enabled.

📸 Screenshots

Screenshot 2024-10-16 at 9 28 34 PM
Screenshot 2024-10-16 at 9 28 24 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 33.16%. Comparing base (0f525fa) to head (7205efe).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/auth/login/login.component.ts 0.00% 14 Missing ⚠️
.../auth/components/environment-selector.component.ts 0.00% 12 Missing ⚠️
...tration-self-hosted-env-config-dialog.component.ts 0.00% 10 Missing ⚠️
apps/browser/src/auth/popup/home.component.ts 0.00% 9 Missing ⚠️
...nv-selector/registration-env-selector.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11597      +/-   ##
==========================================
- Coverage   33.19%   33.16%   -0.04%     
==========================================
  Files        2780     2782       +2     
  Lines       86411    86481      +70     
  Branches    16469    16489      +20     
==========================================
- Hits        28688    28685       -3     
- Misses      55438    55511      +73     
  Partials     2285     2285              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailscad7f9d0-aeb4-4a7c-8827-f362faf472d5

No New Or Fixed Issues Found

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant