Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13212] Fix broken styles/scripts due to FIDO2 content script #11429

Closed
wants to merge 2 commits into from

Conversation

Jamie0
Copy link

@Jamie0 Jamie0 commented Oct 5, 2024

🎟️ Tracking

#11428

📔 Objective

Add document.currentScript.parentNode.removeChild(document.currentScript) to FIDO2 content script, and make the <script /> tag explicitly synchronous. This should ensure the FIDO2 <script /> tag is removed before any scripts run on the page itself, ensuring it is never the first child of documentElement.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@Jamie0 Jamie0 requested a review from a team as a code owner October 5, 2024 15:15
@bitwarden-bot
Copy link

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-13212

@bitwarden-bot bitwarden-bot changed the title Fix broken styles/scripts due to FIDO2 content script [PM-13212] Fix broken styles/scripts due to FIDO2 content script Oct 5, 2024
@cagonzalezcs cagonzalezcs self-assigned this Oct 7, 2024
Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this approach to cleaning up the script is new to me. This seems to work effectively in conjunction with other websites that were having issues with the script cleanup process we originally had in place.

I'm approving this work and moving it to QA for testing...

@Jamie0 Thank you very much for the suggestion!

Copy link
Contributor

github-actions bot commented Oct 7, 2024

Logo
Checkmarx One – Scan Summary & Details2066f8ca-1e4c-4723-bb16-09b8f6203ca6

No New Or Fixed Issues Found

Copy link
Contributor

@cagonzalezcs cagonzalezcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into a couple of issues with the implementation, please let me know if you have any questions.

@cagonzalezcs
Copy link
Contributor

Once again, thank you @Jamie0 for the suggestion.

We've incorporated this work within #11444. Closing this PR as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants