Auth/PM-8112 - UI refresh - Registration Components #11353
Merged
+325
−130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n state change to match figma
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #11353 +/- ##
==========================================
+ Coverage 33.16% 33.19% +0.03%
==========================================
Files 2779 2782 +3
Lines 86236 86439 +203
Branches 16425 16473 +48
==========================================
+ Hits 28597 28692 +95
- Misses 55373 55462 +89
- Partials 2266 2285 +19 ☔ View full report in Codecov by Sentry. |
|
New Issues
Fixed Issues
|
…page title & subtitle when an org invite is in state.
…tion-ui-refresh + merge conflict fixes
…nd let onInit logic figure out what to set based on flows.
…ndling loading and page title and subtitle setting easier.
…utes under extension anon layout
rr-bw
requested changes
Oct 15, 2024
rr-bw
previously approved these changes
Oct 15, 2024
rr-bw
approved these changes
Oct 16, 2024
JaredSnider-Bitwarden
deleted the
auth/pm-8112/registration-ui-refresh
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8112
📔 Objective
To update the UI of the new Registration components to match the new UI refresh designs.
Required medium refactor of the initialization logic in the
RegistrationFinishComponent📸 Screenshots
Web Scenarios
PM-8112.-.Web.-.Registration.w.Email.Verification.-.Standard.flow.succeeds.mov
PM-8112.-.Web.-.Registration.with.Email.Verification.Disabled.-.Succeeds.mov
PM-8112.-.Web.-.Registration.w.Email.Verification.-.Org.Invite.Flow.Succeeds.mov
PM-8112.-.Web.-.Registration.w.Email.Verification.-.Link.expired.scenarios.mov
Desktop Scenarios
PM-8112.-.Desktop.-.Registration.with.Email.Verification.Disabled.-.Succeeds.mov
PM-8112.-.Desktop.-.Registration.w.Email.Verification.-.Standard.flow.succeeds.mov
Extension Scenarios
PM-8112.-.Extension.-.Registration.w.Email.Verification.-.Standard.flow.succeeds.mov
PM-8112.-.Extension.-.Registration.with.Email.Verification.Disabled.-.Succeeds.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes